{{ message }}
gh-141004: Don't trigger run-tests when Tools/check-c-api-docs/ignored_c_api.txt is changed#143583
Merged
ZeroIntensity merged 4 commits intopython:mainfrom Jan 13, 2026
Merged
Conversation
Member
Author
ZeroIntensity
approved these changes
Jan 9, 2026
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
Thanks, I'm fine with this. Since it's right before the weekend, I'll give others a few more days to take a look before merging.
Comment on lines
+26
to
+28
| Path(".github/CODEOWNERS"), | ||
| Path(".pre-commit-config.yaml"), | ||
| Path(".ruff.toml"), |
Member
There was a problem hiding this comment.
It might be worth keeping CONFIGURATION_FILE_NAMES and just flattening it here, but I'm not going to block the PR on it.
hugovk
approved these changes
Jan 9, 2026
hugovk
added
needs backport to 3.13
Member
|
Idle thought, we could write: if not (doc_file or file in RUN_TESTS_IGNORE):As: if not doc_file and file not in RUN_TESTS_IGNORE:I think that's a little clearer? An unrelated condition that could be made clearer in this file is: if not has_platform_specific_change or not platforms_changed:
a
else:
bIs the same as: if not (has_platform_specific_change and platforms_changed):
a
else:
bAnd flip to put the positive first: if has_platform_specific_change and platforms_changed:
b
else:
a |
StanFromIreland
commented
Jan 10, 2026
|
Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 13, 2026
…cs/ignored_c_api.txt` is changed (pythonGH-143583) (cherry picked from commit 1176fac) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 13, 2026
…cs/ignored_c_api.txt` is changed (pythonGH-143583) (cherry picked from commit 1176fac) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-143793 is a backport of this pull request to the 3.14 branch. |
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
…cs/ignored_c_api.txt` is changed (pythonGH-143583)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.