{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
bpo-20181: Convert the readline module to the Argument Clinic - #14326
#14326Merged
serhiy-storchaka merged 5 commits intoJul 12, 2020
python:masterpython/cpython:masterfrom
ZackerySpytz:bpo-20181-readline-module-Argument-ClinicZackerySpytz/cpython:bpo-20181-readline-module-Argument-ClinicCopy head branch name to clipboard
Merged
serhiy-storchaka merged 5 commits intopython:masterpython/cpython:masterfrom ZackerySpytz:bpo-20181-readline-module-Argument-ClinicZackerySpytz/cpython:bpo-20181-readline-module-Argument-ClinicCopy head branch name to clipboard
serhiy-storchaka merged 5 commits into
python:masterpython/cpython:masterfrom
ZackerySpytz:bpo-20181-readline-module-Argument-ClinicZackerySpytz/cpython:bpo-20181-readline-module-Argument-ClinicCopy head branch name to clipboard
Conversation
Contributor
serhiy-storchaka
requested changes
Jul 10, 2020
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…e-module-Argument-Clinic
Contributor
Author
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @serhiy-storchaka: please review the changes made to this pull request. |
serhiy-storchaka
requested changes
Jul 11, 2020
| readline.get_endidx | ||
|
|
||
| /* Get the ending index for the scope of the tab-completion */ | ||
| get the ending index of the completion scope |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix also other docstrings.
Suggested change
| get the ending index of the completion scope | |
| Get the ending index of the completion scope. |
| /*[clinic input] | ||
| readline.get_completer | ||
|
|
||
| Returns current completer function. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use "get" for uniformity with other functions?
At least "return" is more preferable than "returns".
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
serhiy-storchaka
approved these changes
Jul 12, 2020
Member
|
👍 |
|
@serhiy-storchaka: Please replace |
|
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 4, 2020
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
https://bugs.python.org/issue20181