gh-134584: Eliminate redundant refcounting from _BINARY_OP_SUBSCR_LIST_INT by cocolato · Pull Request #142926 · python/cpython · GitHub
Skip to content

gh-134584: Eliminate redundant refcounting from _BINARY_OP_SUBSCR_LIST_INT#142926

Merged
Fidget-Spinner merged 2 commits into
python:mainfrom
cocolato:feat/BINARY_OP_SUBSCR_LIST_INT
Dec 18, 2025
Merged

gh-134584: Eliminate redundant refcounting from _BINARY_OP_SUBSCR_LIST_INT#142926
Fidget-Spinner merged 2 commits into
python:mainfrom
cocolato:feat/BINARY_OP_SUBSCR_LIST_INT

Conversation

@cocolato

@cocolato cocolato commented Dec 18, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Dec 18, 2025
Closed
35 tasks
@Fidget-Spinner

Fidget-Spinner commented Dec 18, 2025

Copy link
Copy Markdown
Member

@cocolato

cocolato commented Dec 18, 2025

Copy link
Copy Markdown
Member Author

@cocolato in the future could you please check on the issue before opening a PR? I already assigned this to someone else. I wont close this PR but please keep that in mind in the future. Otherwise it makes things hard to coordinate.

Sorry about that. I'll close this PR and find other unassigned tasks to work on.

@cocolato cocolato closed this Dec 18, 2025
@Fidget-Spinner

Fidget-Spinner commented Dec 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@cocolato no problem. Would you like to work on _UNPACK_SEQUENCE and _UNPACK_SEQUENCE_LIST? I can assign those to you. From this PR, it looks like you're a very capable contributor :).

@cocolato

cocolato commented Dec 18, 2025

Copy link
Copy Markdown
Member Author

@cocolato no problem. Would you like to work on _UNPACK_SEQUENCE and _UNPACK_SEQUENCE_LIST? I can assign those to you. From this PR, it looks like you're a very capable contributor :).

Thank you for your reply. I'm pleased to work on this！

@Fidget-Spinner

Fidget-Spinner commented Dec 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@cocolato, thanks for taking them up! I will also assign you _UNPACK_SEQUENCE_TUPLE, as it's very much the same thing.

@Fidget-Spinner

Fidget-Spinner commented Dec 18, 2025

Copy link
Copy Markdown
Member

@Fidget-Spinner Fidget-Spinner merged commit 33d94ab into python:main Dec 18, 2025
68 checks passed
cocolato added a commit to cocolato/cpython that referenced this pull request Dec 22, 2025
@cocolato
pythongh-134584: Eliminate redundant refcounting from _BINARY_OP_SUBS…
a6a6316 
…CR_LIST_INT (pythonGH-142926)
@cocolato cocolato deleted the feat/BINARY_OP_SUBSCR_LIST_INT branch January 20, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cocolato @Fidget-Spinner