{{ message }}
GH-142591: Tachyon does not handle non-existent file/module#142592
Merged
pablogsal merged 6 commits intoDec 14, 2025
Conversation
Member
Author
pablogsal
reviewed
Dec 14, 2025
| """Handle live mode for an existing process.""" | ||
| # Check if process exists | ||
| try: | ||
| os.kill(pid, 0) |
Member
There was a problem hiding this comment.
I am not sure this works on windows. On Windows, os.kill() only supports signals SIGTERM, CTRL_C_EVENT, and CTRL_BREAK_EVENT. Signal 0 (which is the Unix idiom for checking if a process exists without sending a signal) is not supported on Windows.
Member
There was a problem hiding this comment.
This also has a TOCTOU problem: the process may die after you check and before we attach
Member
There was a problem hiding this comment.
The fix probably needs to be done more on the line of https://github.com/python/cpython/pull/142655/changes (we should handle this there)
Member
pablogsal
force-pushed
the
tachyon-file-does-not-exist
branch
3 times, most recently
from
fe664f9 to
980b035
Compare
pablogsal
force-pushed
the
tachyon-file-does-not-exist
branch
from
980b035 to
24086c8
Compare
pablogsal
approved these changes
Dec 14, 2025
pablogsal
left a comment
pablogsal
left a comment
Member
There was a problem hiding this comment.
LGTM
Thanks a lot for the PR @savannahostrowski ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This validates script/module/PID exists before starting the profiler. If the target doesn't exist, we now fail fast with a clear error instead of launching an empty TUI.