bpo-20175: Convert Modules/_multiprocessing to the Argument Clinic by ZackerySpytz · Pull Request #14245 · python/cpython · GitHub
Skip to content

bpo-20175: Convert Modules/_multiprocessing to the Argument Clinic - #14245

Merged
serhiy-storchaka merged 3 commits into
python:masterfrom
ZackerySpytz:bpo-20175-_multiprocessing-Argument-Clinic
Jul 12, 2020
Merged

bpo-20175: Convert Modules/_multiprocessing to the Argument Clinic#14245
serhiy-storchaka merged 3 commits into
python:masterfrom
ZackerySpytz:bpo-20175-_multiprocessing-Argument-Clinic

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed.

Comment thread Modules/_multiprocessing/semaphore.c Outdated
/*[clinic input]
_multiprocessing.SemLock.acquire

block as blocking: int = 1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
block as blocking: int = 1
block as blocking: bool(accept={int}) = True

Comment thread Modules/_multiprocessing/semaphore.c Outdated
block as blocking: int = 1
timeout as timeout_obj: object = None

acquire the semaphore/lock

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
acquire the semaphore/lock
Acquire the semaphore/lock.

Comment thread Modules/_multiprocessing/semaphore.c Outdated
/*[clinic input]
_multiprocessing.SemLock.release

release the semaphore/lock

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
release the semaphore/lock
Release the semaphore/lock.

Comment thread Modules/_multiprocessing/semaphore.c Outdated
value: int
maxvalue: int
name: str
unlink: int

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unlink: int
unlink: bool(accept={int})

@bedevere-bot

Copy link
Copy Markdown

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants