Correct memory order of _Py_atomic_store_uint_release by SubbaraoGarlapati · Pull Request #141562 · python/cpython · GitHub
Skip to content

Correct memory order of _Py_atomic_store_uint_release - #141562

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
SubbaraoGarlapati:correct-atomic-method-memory-order
Nov 17, 2025
Merged

Correct memory order of _Py_atomic_store_uint_release#141562
kumaraditya303 merged 2 commits into
python:mainfrom
SubbaraoGarlapati:correct-atomic-method-memory-order

Conversation

@SubbaraoGarlapati

@SubbaraoGarlapati SubbaraoGarlapati commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Change _Py_atomic_store_uint_release() from using memory_order_relaxed to memory_order_release.

@bedevere-app

bedevere-app Bot commented Nov 14, 2025

Copy link
Copy Markdown

@bedevere-app

bedevere-app Bot commented Nov 14, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot

python-cla-bot Bot commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@sharktide

sharktide commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

CC @ZeroIntensity

Also skip news here

sharktide
sharktide suggested changes Nov 15, 2025
View reviewed changes

@sharktide sharktide left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t appear to have a linked issue or be a trivial change

I would create one that explains the problem in detail, unless I am mistaken. :)

@ZeroIntensity

ZeroIntensity commented Nov 15, 2025

Copy link
Copy Markdown
Member

CC @ZeroIntensity

I believe the person you're looking for is @colesbury

To me, this seems trivial; I don't see any need to create an issue, especially since we don't actually use _Py_atomic_store_uint_release anywhere, but I'm going to leave that up to Sam since this is all his code.

@sharktide

sharktide commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

CC @ZeroIntensity

I believe the person you're looking for is @colesbury

To me, this seems trivial; I don't see any need to create an issue, especially since we don't actually use _Py_atomic_store_uint_release anywhere, but I'm going to leave that up to Sam since this is all his code.

Probably for the best

picnixz
picnixz approved these changes Nov 15, 2025
View reviewed changes

@picnixz picnixz left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is correct. We already have the relaxed form for uint (it is located some lines above and not visible in the diff) but we lack its release form.

@colesbury

colesbury commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

LGTM

@kumaraditya303
kumaraditya303 merged commit 7800b78 into python:main Nov 17, 2025
56 checks passed
@colesbury colesbury added the needs backport to 3.14 bugs and security fixes label Nov 17, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 17, 2025

Copy link
Copy Markdown

Thanks @SubbaraoGarlapati for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2025
@SubbaraoGarlapati @miss-islington
fix memory order of _Py_atomic_store_uint_release (pythonGH-141562)
d380b50 
(cherry picked from commit 7800b78)

Co-authored-by: SubbaraoGarlapati <53627478+SubbaraoGarlapati@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Nov 17, 2025

Copy link
Copy Markdown

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 17, 2025
colesbury pushed a commit that referenced this pull request Nov 17, 2025
@miss-islington @SubbaraoGarlapati
[3.14] fix memory order of _Py_atomic_store_uint_release (GH-141562) (
cf141ab 
GH-141663)

(cherry picked from commit 7800b78)

Co-authored-by: SubbaraoGarlapati <53627478+SubbaraoGarlapati@users.noreply.github.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@SubbaraoGarlapati @StanFromIreland
fix memory order of _Py_atomic_store_uint_release (python#141562)
1e42f9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
+1 more reviewer
@sharktide sharktide sharktide requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issue skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SubbaraoGarlapati @sharktide @ZeroIntensity @colesbury @picnixz @kumaraditya303