{{ message }}
gh-141004: Document Py_HASH_* macros#141205
Merged
picnixz merged 7 commits intopython:mainfrom Nov 7, 2025
Merged
Conversation
picnixz
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
picnixz
commented
Nov 7, 2025
Member
Author
Member
|
I already approved this, no need to request. I'm not too familiar with this area, so I'm basically just trusting that you know what you're doing in terms of content. The format and whatnot look fine. |
picnixz
commented
Nov 7, 2025
Member
Author
|
Well.... I included a typo :D (but that's because we have confusing names!!) I will fix it tomorrow but it will be fast (so I won't backport it yet). I knew I shouldn't have left my dev session... |
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Nov 8, 2025
(cherry picked from commit 3989e12) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
added
needs backport to 3.13
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 8, 2025
(cherry picked from commit 3989e12) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-141224 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 8, 2025
(cherry picked from commit 3989e12) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
added a commit
that referenced
this pull request
Nov 8, 2025
picnixz
added a commit
that referenced
this pull request
Nov 8, 2025
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is much more tricky because
Py_HASH_EXTERNALwas never documented and not really supported in the configure script. It would require user-defined defines and other hacks.What I can do is remove the EXTERNAL docs and make a separate bugfix.
📚 Documentation preview 📚: https://cpython-previews--141205.org.readthedocs.build/