gh-141004: document Py_INFINITY and Py_NAN macros by skirpichev · Pull Request #141145 · python/cpython · GitHub
Skip to content

gh-141004: document Py_INFINITY and Py_NAN macros#141145

Merged
vstinner merged 6 commits intopython:mainfrom
skirpichev:document-Py_INFINITY/141004
Nov 11, 2025
Merged

gh-141004: document Py_INFINITY and Py_NAN macros#141145
vstinner merged 6 commits intopython:mainfrom
skirpichev:document-Py_INFINITY/141004

Conversation

@skirpichev
Copy link
Copy Markdown
Member

@skirpichev skirpichev commented Nov 6, 2025 •
edited by github-actions Bot
Loading

@skirpichev skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 6, 2025
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 6, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Nov 6, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 6, 2025
Open
@skirpichev skirpichev mentioned this pull request Nov 6, 2025
Merged
ZeroIntensity
ZeroIntensity reviewed Nov 6, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
StanFromIreland
StanFromIreland reviewed Nov 6, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
@skirpichev @StanFromIreland
Update Doc/c-api/float.rst
33bbedc 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
skirpichev
skirpichev commented Nov 7, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
@skirpichev skirpichev changed the title gh-141004: document Py_INFINITY macro gh-141004: document Py_INFINITY and Py_NAN macros Nov 10, 2025
@skirpichev
Copy link
Copy Markdown
Member Author

skirpichev commented Nov 10, 2025

ZeroIntensity
ZeroIntensity approved these changes Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for humoring me :)

@vstinner vstinner merged commit d694474 into python:main Nov 11, 2025
32 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Nov 11, 2025

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 11, 2025
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Nov 11, 2025

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d69447445cbacf7537bf59c5c683a3b17060312d 3.14

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Nov 11, 2025

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d69447445cbacf7537bf59c5c683a3b17060312d 3.13

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Nov 11, 2025

Merged, thanks.

Sadly, automated backports failed :-( Can you try to backport the change manually to 3.14?

@skirpichev skirpichev deleted the document-Py_INFINITY/141004 branch November 11, 2025 10:19
@skirpichev
Copy link
Copy Markdown
Member Author

skirpichev commented Nov 11, 2025

That's because #141035 wasn't backported. I think we should.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Nov 11, 2025

I would prefer to not backport a deprecation like Py_MATH_El.

@skirpichev

This comment has been minimized.

Sign in to view
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Nov 11, 2025

GH-141399 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 11, 2025
skirpichev added a commit to skirpichev/cpython that referenced this pull request Nov 11, 2025
@skirpichev @StanFromIreland
[3.14] pythongh-141004: document Py_INFINITY and Py_NAN macros (pytho…
d4f56e7 
…nGH-141145)

(cherry picked from commit d694474)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Nov 11, 2025

GH-141400 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Nov 11, 2025
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 11, 2025

vstinner pushed a commit that referenced this pull request Nov 11, 2025
@skirpichev @StanFromIreland
[3.13] gh-141004: document Py_INFINITY and Py_NAN macros (GH-141145) (#…
05e7b0d 
…141400)

(cherry picked from commit d694474)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner pushed a commit that referenced this pull request Nov 11, 2025
@skirpichev @StanFromIreland
[3.14] gh-141004: document Py_INFINITY and Py_NAN macros (GH-141145) (#…
8b94940 
…141399)

(cherry picked from commit d694474)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@skirpichev @StanFromIreland
pythongh-141004: document Py_INFINITY and Py_NAN macros (python#141145)
af9e8c7 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

@vstinner vstinner

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skirpichev @vstinner @bedevere-bot @ZeroIntensity @StanFromIreland