gh-116146: Add C-API to create module from spec and initfunc by itamaro · Pull Request #139196 · python/cpython · GitHub
Skip to content

gh-116146: Add C-API to create module from spec and initfunc#139196

Merged
encukou merged 15 commits intopython:mainfrom
itamaro:gh-116146-create-builtin-initfunc
Nov 14, 2025
Merged

gh-116146: Add C-API to create module from spec and initfunc#139196
encukou merged 15 commits intopython:mainfrom
itamaro:gh-116146-create-builtin-initfunc

Conversation

@itamaro
Copy link
Copy Markdown
Contributor

@itamaro itamaro commented Sep 21, 2025 •
edited
Loading

@bedevere-app bedevere-app Bot mentioned this pull request Sep 21, 2025
Closed
@itamaro itamaro force-pushed the gh-116146-create-builtin-initfunc branch from f9cd705 to 4363e5a Compare September 21, 2025 19:25
@encukou encukou mentioned this pull request Sep 23, 2025
Open
encukou
encukou reviewed Sep 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable.

I'm proposing a replacement for Init functions in PEP-793, but that PEP adds PyModule_FromSlotsAndSpec and PyModule_Exec which should work for similar use cases.
Would it make sense to switch the spec & initfunc arguments to match that proposal?

I'm not sure if the word Builtin in the name is necessary -- is that to match the internal create_builtin? Would something like PyImport_LoadModuleFromInitfuncAndSpec work better?

Do you want to submit this to the C API WG?

Comment thread Python/import.c Outdated
@itamaro
Copy link
Copy Markdown
Contributor Author

itamaro commented Sep 23, 2025

@encukou
Copy link
Copy Markdown
Member

encukou commented Sep 24, 2025

Is the PEP already implemented on main?

No, it's not even accepted :)
I have a slight preference to align the two proposals, in case both make it. I'm checking if you have strong reasons for the order here. No need to update the PR now.

Will do. Should we first decide whether to change this to match PEP 793, or go to the WP with options and get their input?

Just go to the WG :)

@itamaro itamaro mentioned this pull request Sep 24, 2025
Closed
6 tasks
@itamaro
Copy link
Copy Markdown
Contributor Author

itamaro commented Sep 24, 2025

Just go to the WG :)

done :) capi-workgroup/decisions#77

vstinner
vstinner reviewed Sep 26, 2025
View reviewed changes
Comment thread Python/import.c Outdated
@itamaro itamaro force-pushed the gh-116146-create-builtin-initfunc branch from 4363e5a to 781a730 Compare November 8, 2025 18:52
@itamaro
Fix lint
7af34eb
@itamaro
fix CI
35e9e78 
- remove unused `found` variable
- use `my_test_extension` instead of `embedded_ext` (the former is free-threading-ready, the latter prints a warning)
@itamaro itamaro changed the title gh-116146: Add new C-API to create builtin from spec and initfunc gh-116146: Add C-API to create module from spec and initfunc Nov 9, 2025
@itamaro itamaro marked this pull request as ready for review November 9, 2025 01:01
kumaraditya303
kumaraditya303 reviewed Nov 9, 2025
View reviewed changes
Comment thread Python/import.c Outdated
@itamaro @kumaraditya303
Apply Kumar's review suggestion
6aa2fb2 
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@encukou
Copy link
Copy Markdown
Member

encukou commented Nov 11, 2025

I left my suggestions as a PR: itamaro#27

@encukou @itamaro
PyImport_CreateModuleFromInitfunc: Doc & test update (#27)
f652399 
* Test single-phase init as well; don't use private APIs in test
* Doc update

---------

Co-authored-by: Itamar Oren <itamarost@gmail.com>
vstinner
vstinner reviewed Nov 12, 2025
View reviewed changes
Comment thread Doc/c-api/import.rst Outdated
Comment thread Include/cpython/import.h Outdated
Comment thread Programs/_testembed.c Outdated
Comment thread Programs/_testembed.c Outdated
Comment thread Programs/_testembed.c Outdated
Comment thread Python/import.c
@itamaro @vstinner
Apply Victor's review suggestions
c4f1cc8 
Co-authored-by: Victor Stinner <vstinner@python.org>
@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented Nov 12, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@itamaro itamaro force-pushed the gh-116146-create-builtin-initfunc branch from 8f16533 to 1165950 Compare November 12, 2025 16:18
@itamaro
Copy link
Copy Markdown
Contributor Author

itamaro commented Nov 12, 2025

thank you @encukou @vstinner @kumaraditya303 for the review and suggestions!

@encukou are you planning to merge gh-141197 soon? until that is merged, this PR has a docs failure due to referring to the function that you document in gh-141197.

vstinner
vstinner reviewed Nov 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new function PyImport_CreateModuleFromInitfunc() should be documented in Doc/whatsnew/3.15.rst.

Comment thread Misc/NEWS.d/next/C_API/2025-11-08-10-51-50.gh-issue-116146.pCmx6L.rst Outdated
encukou
encukou reviewed Nov 13, 2025
View reviewed changes
Comment thread Doc/c-api/import.rst Outdated
kumaraditya303
kumaraditya303 reviewed Nov 13, 2025
View reviewed changes
Comment thread Include/cpython/import.h Outdated
kumaraditya303
kumaraditya303 reviewed Nov 13, 2025
View reviewed changes
Comment thread Programs/_testembed.c Outdated
kumaraditya303
kumaraditya303 reviewed Nov 13, 2025
View reviewed changes
Comment thread Python/import.c Outdated
@itamaro @encukou
@kumaraditya303 @vstinner
Apply suggestions from code review
79e5d0e 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
@itamaro itamaro requested a review from AA-Turner as a code owner November 13, 2025 15:31
@itamaro itamaro force-pushed the gh-116146-create-builtin-initfunc branch from fabafb5 to fbfde0a Compare November 13, 2025 15:32
vstinner
vstinner approved these changes Nov 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the updates!

@encukou encukou merged commit 1e4e59b into python:main Nov 14, 2025
46 checks passed
encukou added a commit to encukou/cpython that referenced this pull request Nov 14, 2025
@encukou
Link reference to PyModule_Exec added in python#139196
816023d
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Nov 14, 2025

@itamaro itamaro deleted the gh-116146-create-builtin-initfunc branch November 15, 2025 23:40
@itamaro itamaro mentioned this pull request Dec 1, 2025
Closed
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@itamaro @kumaraditya303
@encukou @vstinner @StanFromIreland
pythongh-116146: Add C-API to create module from spec and initfunc (p…
d8c42b4 
…ythonGH-139196)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@itamaro itamaro mentioned this pull request Dec 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

@vstinner vstinner vstinner approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@itamaro @encukou @vstinner @kumaraditya303