gh-138013: Split SignalsTest from test_io.test_general by cmaloney · Pull Request #139079 · python/cpython · GitHub
Skip to content

gh-138013: Split SignalsTest from test_io.test_general - #139079

Merged
vstinner merged 2 commits into
python:mainfrom
cmaloney:split_signals
Sep 19, 2025
Merged

vstinner merged 2 commits into
python:mainfrom
cmaloney:split_signals

Conversation

@cmaloney

@cmaloney cmaloney commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Increase parallelism by splitting out SignalsTest from test_general. SignalsTest takes 24.2 seconds on my dev machine when fully enabled making it the largest part of test_io. Code move done via copy/paste then tweak imports.

After splitting test_io.test_general is down to 10.1 seconds on my dev box with all parts enabled.

Increase parallelism by splitting out `SignalsTest` from test_general.
`SignalsTest` takes 24.2 seconds on my dev machine when fully enabled
making it the largest part of `test_io`. Code move done via copy/paste
then tweak imports.

After splitting `test_io.test_general` is down to 10.1 on my dev box
with all parts enabled.
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 17, 2025
@cmaloney cmaloney changed the title gh-138013 Split SignalsTest from test_io.test_general gh-138013: Split SignalsTest from test_io.test_general Sep 17, 2025
@cmaloney

Copy link
Copy Markdown
Contributor Author

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
vstinner enabled auto-merge (squash) September 18, 2025 12:20
@vstinner
vstinner merged commit 69c6b43 into python:main Sep 19, 2025
43 checks passed
@cmaloney
cmaloney deleted the split_signals branch September 19, 2025 18:30
@vstinner

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants