gh-138013: Remove load_tests in test_io.test_general by cmaloney · Pull Request #138771 · python/cpython · GitHub
Skip to content

gh-138013: Remove load_tests in test_io.test_general - #138771

Merged
vstinner merged 1 commit into
python:mainfrom
cmaloney:no_load_tests
Sep 16, 2025
Merged

gh-138013: Remove load_tests in test_io.test_general#138771
vstinner merged 1 commit into
python:mainfrom
cmaloney:no_load_tests

Conversation

@cmaloney

@cmaloney cmaloney commented Sep 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rely on default test discovery.

Validation:

 # Run before commit
./python -m test test_io -uall,walltime,largefile,cpu,extralargefile -M25G -o --fail-env-changed -j0 --list-cases | sort > old_cases.txt
 # Run after commit
./python -m test test_io -uall,walltime,largefile,cpu,extralargefile -M25G -o --fail-env-changed -j0 --list-cases | sort > new_cases.txt

diff new_cases.txt old_cases.
 # <outputs no changes in case list>

cc: @srittau (GH-138369 where a test was added but wasn't run because of the manual test list)

@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 10, 2025
Closed
@cmaloney cmaloney changed the title gh-138720: Remove load_tests in test_io.test_general gh-138013: Remove load_tests in test_io.test_general Sep 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 10, 2025
Closed
@cmaloney
pythongh-138013: Remove load_tests in test_io.test_general
60c4e8b 
Rely on default test discovery.

Validation:
```bash
 # Run before commit
./python -m test test_io -uall,walltime,largefile,cpu,extralargefile -M25G -o --fail-env-changed -j0 --list-cases | sort > old_cases.txt
 # Run after commit
./python -m test test_io -uall,walltime,largefile,cpu,extralargefile -M25G -o --fail-env-changed -j0 --list-cases | sort > new_cases.txt

diff new_cases.txt old_cases.
 # <outputs no changes in case list>
```
@cmaloney cmaloney mentioned this pull request Sep 10, 2025
Merged
@cmaloney

cmaloney commented Sep 15, 2025

Copy link
Copy Markdown
Contributor Author

vstinner
vstinner approved these changes Sep 16, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice cleanup.

@vstinner
vstinner merged commit ed75160 into python:main Sep 16, 2025
49 checks passed
@bedevere-bot

bedevere-bot commented Sep 16, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO + PGO 3.x (tier-3) has failed when building commit ed75160.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/442/builds/10212) and take a look at the build logs.
  4. Check if the failure is related to this commit (ed75160) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/442/builds/10212

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto-pgo/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.BufferedWriter>:
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto-pgo/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
k

@cmaloney
cmaloney deleted the no_load_tests branch September 16, 2025 09:12
@bedevere-bot

bedevere-bot commented Sep 16, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO 3.x (tier-3) has failed when building commit ed75160.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/567/builds/10128) and take a look at the build logs.
  4. Check if the failure is related to this commit (ed75160) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/567/builds/10128

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.BufferedWriter>:
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
k

@cmaloney

cmaloney commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

s390x bot Test failure is an instance of gh-138720 which GH-138724 should fix. As far as I can tell some changes cause GC to trigger at a different time and run into it.

@bedevere-bot

bedevere-bot commented Sep 16, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 LTO + PGO 3.x (tier-1) has failed when building commit ed75160.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/568/builds/9801) and take a look at the build logs.
  4. Check if the failure is related to this commit (ed75160) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/568/builds/9801

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64.lto-pgo/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.BufferedWriter>:
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64.lto-pgo/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
k

@bedevere-bot

bedevere-bot commented Sep 16, 2025

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cmaloney @bedevere-bot @vstinner @emmatyping