gh-138525: Support single-dash long options and prefix_chars in BooleanOptionalAction#138692
Conversation
serhiy-storchaka
force-pushed
the
BooleanOptionalAction-prefix_chars
branch
from
fe05304 to
bd8247f
Compare
… BooleanOptionalAction -no-foo is generated for -foo. ++no-foo is generated for ++foo. /no-foo is generated for /foo.
serhiy-storchaka
force-pushed
the
BooleanOptionalAction-prefix_chars
branch
from
bd8247f to
4fa348b
Compare
savannahostrowski
left a comment
savannahostrowski
left a comment
There was a problem hiding this comment.
Overall, the implementation here looks good. I've tested it pretty extensively and everything works as expected. We might want to add a test the verifies that single-character options don't get negation variants created (e.g. -n shouldn't get -non).
On a process-related note, I noticed that #138526 was opened earlier for the referenced issue. It might be good to collaborate on existing PRs and/or give this feedback to the contributor (or even ask them if they'd like to try out adding the feature you have in mind). The more robust fix to add this feature isn't too complicated for someone newer to argparse. Might have been a good opportunity to get another active contributor in the module 🙂
This is tested, see the
I opened this PR after seen that PR. As I said in the review, I do not think that approach is correct. |
|
(My objection was to the initial version of #138526, not to the current one. But this PR supersedes it without a need to extend the |
… BooleanOptionalAction (pythonGH-138692) -nofoo is generated for -foo. ++no-foo is generated for ++foo. /nofoo is generated for /foo.
… BooleanOptionalAction (pythonGH-138692) -nofoo is generated for -foo. ++no-foo is generated for ++foo. /nofoo is generated for /foo.
3 participants
-nofoo is generated for -foo.
++no-foo is generated for ++foo.
/nofoo is generated for /foo.
argparse.BooleanOptionalActionsilently failed when used with parser whoseprefix_charshas no'-'#138525📚 Documentation preview 📚: https://cpython-previews--138692.org.readthedocs.build/