gh-116738: Audit thread-safety for termios module by yoney · Pull Request #138395 · python/cpython · GitHub
Skip to content

gh-116738: Audit thread-safety for termios module - #138395

Closed
yoney wants to merge 1 commit into
python:mainfrom
yoney:ft_termios
Closed

gh-116738: Audit thread-safety for termios module#138395
yoney wants to merge 1 commit into
python:mainfrom
yoney:ft_termios

Conversation

@yoney

@yoney yoney commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

This is a placeholder PR to mark the termios module as audited in gh-116738 for thread safety in the free-threading build.

  • The POSIX functions used by termios are marked as MT-Safe in the Linux termios(3). There are no thread safety issues noted in the POSIX documentation.
  • The current CPython implementation wraps posix functions with Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS which assumes they are thread-safe.
  • Additionally, the module tests were run under thread-sanitizer, which did not report any errors.

cc: @mpage @colesbury @Yhg1s

Note: This PR will be closed after termios is marked in gh-116738

@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Sep 2, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Sep 2, 2025
@yoney
yoney marked this pull request as ready for review September 2, 2025 18:39
@vstinner

vstinner commented Sep 3, 2025

Copy link
Copy Markdown
Member

@yoney

yoney commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

@yoney yoney closed this Sep 3, 2025
@yoney
yoney deleted the ft_termios branch October 19, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants