iframe-proxy

JelleZijlstra · 2025-08-26T15:20:04Z

Issue: annotationlib: ref.evaluate() not working for generics as local variables #138151

miss-islington-app · 2025-11-03T15:22:38Z

…thonGH-138164) (cherry picked from commit b1027d4) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

bedevere-app · 2025-11-03T15:22:46Z

GH-140949 is a backport of this pull request to the 3.14 branch.

…H-138164) (#140949) gh-138151: Fix annotationlib handling of multiple nonlocals (GH-138164) (cherry picked from commit b1027d4) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

bedevere-bot · 2025-11-03T16:13:08Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.14 (tier-2) has failed when building commit 08012a9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1772/builds/668) and take a look at the build logs.
Check if the failure is related to this commit (08012a9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1772/builds/668

Failed tests:

test_urllib2net

Failed subtests:

test_ftp - test.test_urllib2net.OtherNetworkTests.test_ftp

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1546, in ftp_open
    fp, retrlen = fw.retrfile(file, type)
                  ~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1806, in retrfile
    conn, retrlen = self.ftp.ntransfercmd(cmd)
                    ~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/ftplib.py", line 354, in ntransfercmd
    conn = socket.create_connection((host, port), self.timeout,
                                    source_address=self.source_address)
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 870, in create_connection
    raise exceptions[0]
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 855, in create_connection
    sock.connect(sa)
    ~~~~~~~~~~~~^^^^
TimeoutError: timed out


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 260, in _test_urls
    f = urlopen(url, req, support.INTERNET_TIMEOUT)
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 28, in wrapped
    return _retry_thrice(func, exc, *args, **kwargs)
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 24, in _retry_thrice
    raise last_exc
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 20, in _retry_thrice
    return func(*args, **kwargs)
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 487, in open
    response = self._open(req, data)
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 504, in _open
    result = self._call_chain(self.handle_open, protocol, protocol +
                              '_open', req)
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 464, in _call_chain
    result = func(*args)
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1556, in ftp_open
    raise URLError(f"ftp error: {exp}") from exp
urllib.error.URLError: <urlopen error ftp error: timed out>

Thanks to python/cpython#138164 (included in 3.14.1), Python is now able to preserve references when building the forward ref object, and so calling `_eval_type()` on the individual annotations works as expected.

…thon#138164)

pythongh-138151: Fix annotationlib handling of multiple nonlocals

1c86ad9

bedevere-app Bot added the awaiting core review label Aug 26, 2025

JelleZijlstra added needs backport to 3.14 bugs and security fixes and removed awaiting core review labels Aug 26, 2025

bedevere-app Bot mentioned this pull request Aug 26, 2025

annotationlib: ref.evaluate() not working for generics as local variables #138151

Closed

StanFromIreland added the awaiting core review label Aug 26, 2025

JelleZijlstra mentioned this pull request Sep 6, 2025

gh-138151: Fix ForwardRef.evaluate() for locally defined generics #138161

Closed

Merge branch 'main' into annolib-nonlocal

26ef202

JelleZijlstra merged commit b1027d4 into python:main Nov 3, 2025
46 checks passed

bedevere-app Bot removed the awaiting core review label Nov 3, 2025

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 3, 2025

This was referenced Nov 4, 2025

gh-137969: Fix double evaluation of ForwardRefs which rely on globals #140974

Merged

annotationlib: ref.evaluate(format=Format.FORWARDREF) returns a ForwardRef with a copied __globals__ that no longer updates #137969

Open

Viicos mentioned this pull request Dec 3, 2025

Remove xfail marker on a PEP 649 related test pydantic/pydantic#12609

Merged

5 tasks

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025

pythongh-138151: Fix annotationlib handling of multiple nonlocals (py…

552abfa

…thon#138164)

Glinte mentioned this pull request Jan 13, 2026

[Bug] CPython 3.14.2 + PEP 649 annotationlib.ForwardRef + PEP 484 self-reference = TypeError: unhashable type: 'cell' 😨 beartype/beartype#610

Closed

johnslavik mentioned this pull request Jan 14, 2026

Python 3.14.1+ annotationlib regression: ForwardRef.__hash__ raises TypeError: unhashable type: 'cell' #143831

Closed

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-138151: Fix annotationlib handling of multiple nonlocals#138164

gh-138151: Fix annotationlib handling of multiple nonlocals#138164
JelleZijlstra merged 2 commits intopython:mainfrom
JelleZijlstra:annolib-nonlocal

JelleZijlstra commented Aug 26, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

Uh oh!

miss-islington-app Bot commented Nov 3, 2025

Uh oh!

bedevere-app Bot commented Nov 3, 2025

Uh oh!

bedevere-bot commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

JelleZijlstra commented Aug 26, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Nov 3, 2025

Uh oh!

bedevere-app Bot commented Nov 3, 2025

Uh oh!

bedevere-bot commented Nov 3, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JelleZijlstra commented Aug 26, 2025 •

edited by bedevere-app Bot

Loading