gh-73487: Convert _decimal to use Argument Clinic (part 5) by skirpichev · Pull Request #137948 · python/cpython · GitHub
Skip to content

gh-73487: Convert _decimal to use Argument Clinic (part 5) - #137948

Merged
AA-Turner merged 5 commits into
python:mainfrom
skirpichev:ac-decimal/73487-pt5
Aug 21, 2025
Merged

AA-Turner merged 5 commits into
python:mainfrom
skirpichev:ac-decimal/73487-pt5

Conversation

@skirpichev

@skirpichev skirpichev commented Aug 19, 2025

Copy link
Copy Markdown
Member

Comment thread Modules/_decimal/_decimal.c
Comment thread Modules/_decimal/_decimal.c
@skirpichev
skirpichev force-pushed the ac-decimal/73487-pt5 branch from f1ee85f to e4d3775 Compare August 21, 2025 02:29
@skirpichev
skirpichev marked this pull request as ready for review August 21, 2025 02:36

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to add the remaining macros to this PR?:

  • Dec_CONTEXT_GET_SSIZE
  • Dec_CONTEXT_GET_ULONG
  • Dec_UnaryNumberMethod
  • Dec_BinaryNumberMethod
  • DecCtx_BoolFunc
  • DecCtx_BoolFunc_NO_CTX
  • DecCtx_BinaryFunc_NO_CTX

Comment thread Modules/_decimal/_decimal.c Outdated
Comment thread Modules/_decimal/_decimal.c Outdated
Comment thread Modules/_decimal/_decimal.c Outdated
Comment thread Modules/_decimal/_decimal.c Outdated
Comment thread Modules/_decimal/_decimal.c Outdated
skirpichev and others added 2 commits August 21, 2025 06:00
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@skirpichev
skirpichev force-pushed the ac-decimal/73487-pt5 branch from f32830b to 5d9dee8 Compare August 21, 2025 03:24
@skirpichev

Copy link
Copy Markdown
Member Author

@skirpichev
skirpichev force-pushed the ac-decimal/73487-pt5 branch from 5d9dee8 to 94537e1 Compare August 21, 2025 03:55
@skirpichev

Copy link
Copy Markdown
Member Author

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Comment thread Modules/_decimal/_decimal.c Outdated
@AA-Turner
AA-Turner merged commit bb8791c into python:main Aug 21, 2025
46 checks passed
@skirpichev
skirpichev deleted the ac-decimal/73487-pt5 branch August 21, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants