gh-73487: Convert _decimal to use Argument Clinic (part 3) by skirpichev · Pull Request #137844 · python/cpython · GitHub
Skip to content

gh-73487: Convert _decimal to use Argument Clinic (part 3) - #137844

Merged
AA-Turner merged 3 commits into
python:mainfrom
skirpichev:ac-decimal/73487-pt3
Aug 19, 2025
Merged

AA-Turner merged 3 commits into
python:mainfrom
skirpichev:ac-decimal/73487-pt3

Conversation

@skirpichev

@skirpichev skirpichev commented Aug 16, 2025

Copy link
Copy Markdown
Member

@skirpichev
skirpichev force-pushed the ac-decimal/73487-pt3 branch from 911c957 to bbdd366 Compare August 18, 2025 13:43
@skirpichev
skirpichev marked this pull request as ready for review August 18, 2025 13:56
@skirpichev

Copy link
Copy Markdown
Member Author

Comment thread Modules/_decimal/_decimal.c Outdated
Comment thread Modules/_decimal/_decimal.c Outdated
Comment thread Modules/_decimal/_decimal.c Outdated
Comment thread Modules/_decimal/_decimal.c Outdated
module _decimal
class _decimal.Decimal "PyObject *" "&dec_spec"
class _decimal.Context "PyObject *" "&ctx_spec"
class _decimal.Context "PyObject *" "&context_spec"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why rename?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's how actually spec variable named. Mostly useful for search now.

@AA-Turner

Copy link
Copy Markdown
Member

The docstring changes all look reasonable to me.

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @AA-Turner's suggestions. 👍

Comment thread Modules/_decimal/_decimal.c
Comment thread Modules/_decimal/_decimal.c Outdated
Comment thread Modules/_decimal/_decimal.c Outdated
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@skirpichev
skirpichev force-pushed the ac-decimal/73487-pt3 branch from f5970f8 to 05c6041 Compare August 19, 2025 01:06
@skirpichev

Copy link
Copy Markdown
Member Author

@AA-Turner
AA-Turner merged commit 9cb9130 into python:main Aug 19, 2025
42 checks passed
@skirpichev
skirpichev deleted the ac-decimal/73487-pt3 branch August 19, 2025 08:33
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
…ython#137844)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants