{{ message }}
gh-73487: Convert _decimal to use Argument Clinic (part 3) - #137844
Merged
Merged
Conversation
skirpichev
force-pushed
the
ac-decimal/73487-pt3
branch
2 times, most recently
from
August 16, 2025 07:59
04b5daf to
91d1402
Compare
skirpichev
force-pushed
the
ac-decimal/73487-pt3
branch
from
August 17, 2025 16:50
91d1402 to
911c957
Compare
skirpichev
force-pushed
the
ac-decimal/73487-pt3
branch
from
August 18, 2025 13:43
911c957 to
bbdd366
Compare
skirpichev
marked this pull request as ready for review
August 18, 2025 13:56
Member
Author
AA-Turner
approved these changes
Aug 18, 2025
| module _decimal | ||
| class _decimal.Decimal "PyObject *" "&dec_spec" | ||
| class _decimal.Context "PyObject *" "&ctx_spec" | ||
| class _decimal.Context "PyObject *" "&context_spec" |
Member
Author
There was a problem hiding this comment.
It's how actually spec variable named. Mostly useful for search now.
Member
|
The docstring changes all look reasonable to me. |
serhiy-storchaka
approved these changes
Aug 18, 2025
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM with @AA-Turner's suggestions. 👍
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
skirpichev
force-pushed
the
ac-decimal/73487-pt3
branch
from
August 19, 2025 01:06
f5970f8 to
05c6041
Compare
Member
Author
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…ython#137844) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.