iframe-proxy

serhiy-storchaka · 2019-05-31T14:38:31Z

Based on #12620 but contains only changes that can be applied in 3.8. E.g. only getting rid of *args and name tricks and making self and cls positional-only.

https://bugs.python.org/issue37116

gvanrossum

All LGTM. Very nice cleanups!

It looks like we technically have to add / whenever there's a **kwds (assuming the kwds is passed through and could contain any key)...

gvanrossum · 2019-05-31T15:55:50Z

 import re as _re
 from collections import ChainMap as _ChainMap

+_sentinel_dict = {}


Why not use object()? IIUC all the code below checks for its identity first and then substitutes another dict.

Because semantically the default value for the mapping parameter is an empty dict. The check mapping is _sentinel_dict is merely an optimization (we can avoid to create a ChainMap in this case).

pablogsal · 2019-05-31T18:08:38Z

Thank you very much @serhiy-storchaka for working on this 🎉

ilevkivskyi

typing/abc/collections code LGTM.

serhiy-storchaka · 2019-06-01T06:40:07Z

Yes, we can add / in most cases whenever there's a **kwds.

With bpo-36518 we should not even add it if all positional arguments are required (this covers the majority of cases).

serhiy-storchaka · 2019-06-01T06:45:00Z

@pablogsal The two last bugs related to positional-only arguments I found when worked on this issue.

tirkarthi

mock changes LGTM. There are few places where _mock_self is used in the async helpers later assigning to self following older pattern. I will try to change them in another PR so that this is good for beta 1. Thanks Serhiy.

bedevere-bot · 2019-06-01T09:50:12Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Windows7 3.x has failed when building commit 2085bd0.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/58/builds/2538) and take a look at the build logs.
Check if the failure is related to this commit (2085bd0) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/58/builds/2538

Click to see traceback logs

Traceback (most recent call last):
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_venv.py", line 327, in test_multiprocessing
    out, err = check_output([envpy, '-c',
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_venv.py", line 42, in check_output
    raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '['d:\\temp\\tmpzz1z4c8u\\Scripts\\python_d.exe', '-c', 'from multiprocessing import Pool; print(Pool(1).apply_async("Python".lower).get(3))']' returned non-zero exit status 3221225477.

----------------------------------------------------------------------

Ran 16 tests in 144.483s

FAILED (errors=1, skipped=2)


Traceback (most recent call last):
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_venv.py", line 327, in test_multiprocessing
    out, err = check_output([envpy, '-c',
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_venv.py", line 42, in check_output
    raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '['d:\\temp\\tmp_qt0ywa6\\Scripts\\python_d.exe', '-c', 'from multiprocessing import Pool; print(Pool(1).apply_async("Python".lower).get(3))']' returned non-zero exit status 3221225477.

----------------------------------------------------------------------

Ran 16 tests in 65.325s

FAILED (errors=1, skipped=2)

…GH-13700)

serhiy-storchaka added 9 commits March 29, 2019 19:34

Use PEP 570 syntax for positional-only parameters.

c10b324

Merge branch 'master' into use-pep-570

8004b5d

Revert changes in argparse and optparse.

e68b934

Merge branch 'master' into use-pep-570

8cb95e0

Remove unneeded settings of __text_signature__.

ba68739

Merge branch 'master' into use-pep-570

2cf894d

Merge branch 'master' into use-pep-570

3a52252

Fix tests.

1529d55

Keep changes that can be applied in 3.8.

f12a89c

serhiy-storchaka requested review from 1st1, ericvsmith, gvanrossum, ilevkivskyi, rhettinger and terryjreedy as code owners May 31, 2019 14:38

the-knights-who-say-ni added the CLA signed label May 31, 2019

bedevere-bot added the awaiting core review label May 31, 2019

serhiy-storchaka added the skip news label May 31, 2019

serhiy-storchaka changed the title ~~Use PEP 570 syntax for positional-only parameters.~~ bpo-37116: Use PEP 570 syntax for positional-only parameters. May 31, 2019

auvipy approved these changes May 31, 2019

View reviewed changes

gvanrossum approved these changes May 31, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels May 31, 2019

tirkarthi reviewed May 31, 2019

View reviewed changes

Comment thread Lib/unittest/case.py

tirkarthi reviewed May 31, 2019

View reviewed changes

Comment thread Lib/unittest/mock.py

tirkarthi reviewed May 31, 2019

View reviewed changes

Comment thread Lib/unittest/mock.py

ilevkivskyi approved these changes May 31, 2019

View reviewed changes

Update addClassCleanup and some mock methods.

c504dc9

tirkarthi approved these changes Jun 1, 2019

View reviewed changes

serhiy-storchaka added 3 commits June 1, 2019 10:09

Get rid of _mock_self.

6b69757

Remove a note about deprecation from What's New.

105c264

Update the documentation.

aa4bdae

serhiy-storchaka requested a review from a team as a code owner June 1, 2019 07:38

serhiy-storchaka merged commit 2085bd0 into python:master Jun 1, 2019

bedevere-bot removed the awaiting merge label Jun 1, 2019

serhiy-storchaka deleted the use-pep-570-38 branch June 1, 2019 08:00

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020

bpo-37116: Use PEP 570 syntax for positional-only parameters. (python…

6ac94bc

…GH-13700)

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

serhiy-storchaka commented May 31, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum May 31, 2019

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Jun 1, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pablogsal commented May 31, 2019

Uh oh!

Uh oh!

Uh oh!

ilevkivskyi left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Jun 1, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka commented Jun 1, 2019

Uh oh!

tirkarthi left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Jun 1, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

serhiy-storchaka commented May 31, 2019 •

edited by bedevere-bot

Loading

serhiy-storchaka commented Jun 1, 2019 •

edited by bedevere-bot

Loading