bpo-37096: Add large-file tests for modules using sendfile(2) by giampaolo · Pull Request #13676 · python/cpython · GitHub
Skip to content

bpo-37096: Add large-file tests for modules using sendfile(2) - #13676

Merged
giampaolo merged 4 commits into
python:masterfrom
giampaolo:sendfile-large-file-test
Sep 30, 2019
Merged

bpo-37096: Add large-file tests for modules using sendfile(2)#13676
giampaolo merged 4 commits into
python:masterfrom
giampaolo:sendfile-large-file-test

Conversation

@giampaolo

@giampaolo giampaolo commented May 30, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels May 30, 2019
@asvetlov

asvetlov commented May 30, 2019

Copy link
Copy Markdown
Contributor

@giampaolo
giampaolo merged commit 5bcc6d8 into python:master Sep 30, 2019
@giampaolo
giampaolo deleted the sendfile-large-file-test branch September 30, 2019 04:51
@bedevere-bot

bedevere-bot commented Sep 30, 2019

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARMv7 Debian buster 3.x has failed when building commit 5bcc6d8.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/176/builds/1372) and take a look at the build logs.
  4. Check if the failure is related to this commit (5bcc6d8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/176/builds/1372

Failed tests:

  • test_largefile

Failed subtests:

  • test_it - test.test_largefile.TestCopyfile
  • test_it - test.test_largefile.TestSocketSendfile

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

405 tests OK.

10 slowest tests:

  • test_gdb: 6 min 39 sec
  • test_tokenize: 6 min 10 sec
  • test_multiprocessing_spawn: 5 min 55 sec
  • test_tools: 5 min 21 sec
  • test_concurrent_futures: 4 min 18 sec
  • test_lib2to3: 4 min 8 sec
  • test_unicodedata: 3 min 17 sec
  • test_asyncio: 3 min 7 sec
  • test_smtpnet: 3 min 1 sec
  • test_multiprocessing_forkserver: 2 min 22 sec

1 test failed:
test_largefile

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_largefile

Total duration: 14 min 10 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/ssd/buildbot/buildarea/3.x.gps-ubuntu-exynos5-armv7l/build/Lib/test/test_largefile.py", line 207, in test_it
    client.sendfile(f)
  File "/ssd/buildbot/buildarea/3.x.gps-ubuntu-exynos5-armv7l/build/Lib/socket.py", line 483, in sendfile
    return self._sendfile_use_sendfile(file, offset, count)
  File "/ssd/buildbot/buildarea/3.x.gps-ubuntu-exynos5-armv7l/build/Lib/socket.py", line 386, in _sendfile_use_sendfile
    sent = os_sendfile(sockno, fileno, offset, blocksize)
OverflowError: Python int too large to convert to C ssize_t


Traceback (most recent call last):
  File "/ssd/buildbot/buildarea/3.x.gps-ubuntu-exynos5-armv7l/build/Lib/test/test_largefile.py", line 160, in test_it
    shutil.copyfile(TESTFN, TESTFN2)
  File "/ssd/buildbot/buildarea/3.x.gps-ubuntu-exynos5-armv7l/build/Lib/shutil.py", line 266, in copyfile
    _fastcopy_sendfile(fsrc, fdst)
  File "/ssd/buildbot/buildarea/3.x.gps-ubuntu-exynos5-armv7l/build/Lib/shutil.py", line 145, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
OverflowError: Python int too large to convert to C ssize_t

@bedevere-bot

bedevere-bot commented Sep 30, 2019

Copy link
Copy Markdown

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@giampaolo Jake Taylor
bpo-37096: Add large-file tests for modules using sendfile(2) (python…
a8babcf 
…GH-13676)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@giampaolo @asvetlov @bedevere-bot @the-knights-who-say-ni