bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [task] [WIP] by eamanu · Pull Request #13670 · python/cpython · GitHub
Skip to content

bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [task] [WIP] - #13670

Closed
eamanu wants to merge 3 commits into
python:masterfrom
eamanu:bpo-36373-task
Closed

bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [task] [WIP]#13670
eamanu wants to merge 3 commits into
python:masterfrom
eamanu:bpo-36373-task

Conversation

@eamanu

@eamanu eamanu commented May 30, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

First step: tasks.py

https://bugs.python.org/issue36373

@eamanu
bpo-36373: Deprecate explicit loop parameter
d4e4911 
This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

First step: tasks.py
@eamanu
eamanu requested review from 1st1 and asvetlov as code owners May 30, 2019 00:50
@eamanu eamanu changed the title bpo-36373:Deprecate explicit loop parameter in all public asyncio APIs bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs May 30, 2019
tirkarthi
tirkarthi reviewed May 30, 2019
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle DeprecationWarning in the tests. Running with -Werror would give test failures due to warnings.

asvetlov
asvetlov requested changes May 30, 2019
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @tirkarthi
./python -Werror -m test should pass
You can find the following command useful in development:
`./python -Werror -m test -v test_asyncio"

@bedevere-bot

bedevere-bot commented May 30, 2019

Copy link
Copy Markdown

@eamanu eamanu changed the title bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [task] Jun 5, 2019
asvetlov
asvetlov requested changes Jun 5, 2019
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the PR with ./python -Werror -m test --check-env-changed -v test_asyncio and make sure that the test run is succeded.

Comment thread Lib/asyncio/tasks.py Outdated
"""

def __init__(self, children, *, loop=None):
if loop:

@asvetlov asvetlov Jun 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is redundant: asyncio.gather() always passes loop to internal _GatheringFuture constructor.

@eamanu eamanu mentioned this pull request Jun 5, 2019
Merged
asvetlov
asvetlov reviewed Jun 5, 2019
View reviewed changes
Comment thread Lib/asyncio/tasks.py Outdated

def __init__(self, coro, *, loop=None, name=None):
if loop:
warnings.warn("The loop argument is deprecated since Python 3.8, "

@asvetlov asvetlov Jun 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task is called with explicit loop by loop.create_task() method, please drop the check

@codecov

codecov Bot commented Jun 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #13670 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13670      +/-   ##
==========================================
- Coverage   82.78%   82.78%   -0.01%     
==========================================
  Files        1842     1842              
  Lines      559265   559276      +11     
  Branches    41382    41387       +5     
==========================================
- Hits       463009   462990      -19     
- Misses      87188    87209      +21     
- Partials     9068     9077       +9
Impacted Files Coverage Δ
Lib/asyncio/tasks.py 94.73% <66.66%> (-0.77%) ⬇️
Lib/idlelib/runscript.py 19.09% <0%> (-1.82%) ⬇️
Lib/idlelib/scrolledlist.py 36.6% <0%> (-1.79%) ⬇️
Lib/test/test_asyncio/functional.py 70.65% <0%> (-1.64%) ⬇️
Lib/heapq.py 94.53% <0%> (-1.57%) ⬇️
Lib/idlelib/squeezer.py 91.94% <0%> (-1.35%) ⬇️
Lib/test/test_capi.py 93.4% <0%> (-0.8%) ⬇️
Lib/_weakrefset.py 59.18% <0%> (-0.69%) ⬇️
Lib/socketserver.py 80% <0%> (-0.34%) ⬇️
Lib/test/test_random.py 96.43% <0%> (-0.31%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8087831...0706c1b. Read the comment docs.

@eamanu eamanu changed the title bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [task] bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [task] [WIP] Jun 8, 2019
@asvetlov

asvetlov commented Sep 12, 2019

Copy link
Copy Markdown
Contributor

@asvetlov asvetlov closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov requested changes
@tirkarthi tirkarthi tirkarthi left review comments
@1st1 1st1 Awaiting requested review from 1st1
+1 more reviewer
@Carreau Carreau Carreau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eamanu @bedevere-bot @asvetlov @Carreau @tirkarthi @the-knights-who-say-ni