gh-127146: Report uid in Emscripten + node as native uid - #136509
Conversation
Fixes `test_netrc.NetrcTestCase.test_security`, which was getting mad that we reported the uid of a file correctly but reported the user's uid as 0.
1fc5975 to
f2a7202
Compare
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit f2a7202 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136509%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
The buildbot isn't happy with the new C file... |
|
Indeed, there is a missing |
|
How do the |
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 789681e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136509%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
I'm not sure if the buildbot issue is a permissions thing, or if the buildbot directive has to be a comment on its own. I've asked on Discord for clarification; in the meantime, I've kicked off a build for you. |
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
Looks like that has done the job!
|
Looks like it still isn't happy - I thought the "up-to-date" error was a configure.ac thing, but it looks like a linting check on the new C file... |
^ this, or at least the comment has to start with the buildbot command. Improvements welcome :) |
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit b8df7ea 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136509%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot ios|android |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit b8df7ea 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136509%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot this-doesnt-exist |
|
The regex 'this-doesnt-exist' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
|
(The buildbot trigger noise was part of testing python/devguide#1605; the iOS/Android builds aren't actually required for testing) |
|
With the platform specific exclusion in the c-analyzer, this is now passing the netrc test; we're down to just the pydoc test failure. |
|
Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…nGH-136509) Corrects the handling of getuid on emscripten, which was consistently reporting as 0. (cherry picked from commit e81c4e8) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
|
GH-136699 is a backport of this pull request to the 3.14 branch. |
…n#136509) Corrects the handling of getuid on emscripten, which was consistently reporting as 0.
…n#136509) Corrects the handling of getuid on emscripten, which was consistently reporting as 0.
…pythonGH-136509) (python#136699) Corrects the handling of getuid on emscripten, which was consistently reporting as 0. (cherry picked from commit e81c4e8) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
4 participants
Fixes
test_netrc.NetrcTestCase.test_security, which was getting mad that we reported the uid of a file correctly but reported the user's uid as 0.cc @freakboy3742.