{{ message }}
gh-98388: add tests for happy eyeballs - #136368
Merged
Merged
Conversation
LamentXU123
suggested changes
Jul 7, 2025
Contributor
There was a problem hiding this comment.
In the PEP 8, style guide, we limit all lines to a maximum of 79 characters.
(EDIT: Removed loud and redundant screenshot image.)
Member
gvanrossum
approved these changes
Jul 7, 2025
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
LGTM. Let's ignore the suggestion of breaking long-ish lines.
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests from #98389 with merge conflicts fixed and applied suggestions. I have not added staggered tests as new staggered tests already exists.
Closes #98388
Co-Authored-By: twisteroid ambassador twisteroidambassador@users.noreply.github.com