gh-136315: Fix skipped multithreading test in test_zstd by emmatyping · Pull Request #136320 · python/cpython · GitHub
Skip to content

gh-136315: Fix skipped multithreading test in test_zstd - #136320

Merged
gpshead merged 1 commit into
python:mainfrom
emmatyping:fix-skipped-multithreading-test
Jul 5, 2025
Merged

gpshead merged 1 commit into
python:mainfrom
emmatyping:fix-skipped-multithreading-test

Conversation

@emmatyping

@emmatyping emmatyping commented Jul 5, 2025

Copy link
Copy Markdown
Member

@emmatyping
emmatyping requested a review from gpshead July 5, 2025 17:07
@emmatyping emmatyping added skip news needs backport to 3.14 bugs and security fixes labels Jul 5, 2025
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jul 5, 2025

@Rogdham Rogdham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

I can confirm that the test is now run:

$ ./python -c 'from compression.zstd import *; print(CompressionParameter.nb_workers.bounds() != (0, 0))'
True
$ ./python -m test.test_zstd -k test_zstd_multithread_compress -v
test_zstd_multithread_compress (__main__.CompressorTestCase.test_zstd_multithread_compress) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.229s

OK

@gpshead
gpshead enabled auto-merge (squash) July 5, 2025 17:22
@gpshead
gpshead merged commit 5dac137 into python:main Jul 5, 2025
@miss-islington-app

Copy link
Copy Markdown

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2025
…GH-136320)

Fix skipped test in test_zstd
(cherry picked from commit 5dac137)

Co-authored-by: Emma Smith <emma@emmatyping.dev>
@bedevere-app

bedevere-app Bot commented Jul 5, 2025

Copy link
Copy Markdown

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 5, 2025
gpshead pushed a commit that referenced this pull request Jul 5, 2025
…6320) (#136322)

gh-136315: Fix skipped multithreading test in test_zstd (GH-136320)

Fix skipped test in test_zstd
(cherry picked from commit 5dac137)

Co-authored-by: Emma Smith <emma@emmatyping.dev>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants