iframe-proxy

picnixz · 2025-06-22T14:30:27Z

Issue: netrc security check may fail on WASI due to the lack of os.getuid #135815

serhiy-storchaka

LGTM.

Added a couple of suggestions, it is up to you.

serhiy-storchaka · 2025-06-22T16:11:41Z

                    (f"~/.netrc file owner ({fowner}, {user}) does not match"
                     " current user"))


The message looks weird. Would not be better to rewrite in in the following way?

(f"~/.netrc file owner ({fowner}) does not match" f" current user ({user})"))

I'll change it in a follow-up PR so that only unstable branches are affected.

miss-islington-app · 2025-06-22T19:48:09Z

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

…ng (pythonGH-135816) (cherry picked from commit b57b619) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app · 2025-06-22T19:48:18Z

GH-135825 is a backport of this pull request to the 3.14 branch.

…ng (pythonGH-135816) (cherry picked from commit b57b619) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app · 2025-06-22T19:48:22Z

GH-135826 is a backport of this pull request to the 3.13 branch.

…ing (GH-135816) (#135826) gh-135815: skip `netrc` security checks if `os.getuid` is missing (GH-135816) (cherry picked from commit b57b619) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

…ing (GH-135816) (#135825) gh-135815: skip `netrc` security checks if `os.getuid` is missing (GH-135816) (cherry picked from commit b57b619) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-bot · 2025-06-23T00:12:52Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Refleaks 3.14 (tier-2) has failed when building commit 10f9db9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1710/builds/192) and take a look at the build logs.
Check if the failure is related to this commit (10f9db9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1710/builds/192

Failed tests:

test_perf_profiler

Failed subtests:

test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated
test_timerfd_select - test.test_os.TimerfdTests.test_timerfd_select
test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 399, in test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 403 events and lost 1[34 chars]\n\n' != ''
- Warning:
- Processed 403 events and lost 1 chunks!
- 
- Check IO/CPU overload!
- 


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 399, in test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 429 events and lost 1[34 chars]\n\n' != ''
- Warning:
- Processed 429 events and lost 1 chunks!
- 
- Check IO/CPU overload!
- 


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 373, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 653 events and lost 1[34 chars]\n\n' != ''
- Warning:
- Processed 653 events and lost 1 chunks!
- 
- Check IO/CPU overload!
- 


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_os.py", line 4450, in test_timerfd_select
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 2 != 1

Before python#135816 it was skipped because pwd is missing on Emscripten. Now it isn't skipped because the test no longer requires pwd but it still doesn't work on Emscripten.

…ng (python#135816)

bedevere-app Bot added the awaiting core review label Jun 22, 2025

bedevere-app Bot mentioned this pull request Jun 22, 2025

netrc security check may fail on WASI due to the lack of os.getuid #135815

Closed

fix netrc security checks on WASI

d2a13f6

picnixz force-pushed the fix/netrc/wasi-security-check-135815 branch from c472cc9 to d2a13f6 Compare June 22, 2025 14:34

picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 22, 2025

python deleted a comment from bedevere-bot Jun 22, 2025

picnixz requested a review from serhiy-storchaka June 22, 2025 15:06

serhiy-storchaka approved these changes Jun 22, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 22, 2025

avoid calling os.getuid() twice

cbe216a

picnixz enabled auto-merge (squash) June 22, 2025 19:31

picnixz merged commit b57b619 into python:main Jun 22, 2025

bedevere-app Bot removed the awaiting merge label Jun 22, 2025

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 22, 2025

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 22, 2025

picnixz deleted the fix/netrc/wasi-security-check-135815 branch June 22, 2025 19:49

hoodmane mentioned this pull request Jul 3, 2025

gh-127146: Skip test_netrc.test_security on Emscripten #136227

Closed

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025

pythongh-135815: skip netrc security checks if os.getuid is missi…

c620360

…ng (python#135816)

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025

pythongh-135815: skip netrc security checks if os.getuid is missi…

6ed74fb

…ng (python#135816)

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025

pythongh-135815: skip netrc security checks if os.getuid is missi…

01bb4ef

…ng (python#135816)

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025

pythongh-135815: skip netrc security checks if os.getuid is missi…

75935fc

…ng (python#135816)

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

Uh oh!

gh-135815: skip `netrc` security checks if `os.getuid` is missing - #135816

gh-135815: skip `netrc` security checks if `os.getuid` is missing#135816
picnixz merged 2 commits into
python:mainfrom
picnixz:fix/netrc/wasi-security-check-135815

picnixz commented Jun 22, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

serhiy-storchaka left a comment

Uh oh!

Uh oh!

serhiy-storchaka Jun 22, 2025

Uh oh!

picnixz Jun 22, 2025

Uh oh!

miss-islington-app Bot commented Jun 22, 2025

Uh oh!

bedevere-app Bot commented Jun 22, 2025

Uh oh!

bedevere-app Bot commented Jun 22, 2025

Uh oh!

bedevere-bot commented Jun 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		(f"~/.netrc file owner ({fowner}, {user}) does not match"
		" current user"))

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

picnixz commented Jun 22, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

serhiy-storchaka Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

picnixz Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Jun 22, 2025

Uh oh!

bedevere-app Bot commented Jun 22, 2025

Uh oh!

bedevere-app Bot commented Jun 22, 2025

Uh oh!

bedevere-bot commented Jun 23, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

picnixz commented Jun 22, 2025 •

edited by bedevere-app Bot

Loading