{{ message }}
Revert "gh-135410: use a critical section around StringIO.__next__ (#135412)" - #135439
Merged
Conversation
…xt__` (python#135412)" This reverts commit e6c3039.
Contributor
corona10
approved these changes
Jun 12, 2025
Member
There was a problem hiding this comment.
Let’s revert this change and revisit what better approaches we can take.
If we can’t guarantee that the Python version is thread-safe, then we should document that StringIO is not thread-safe. it also means we don’t need to guarantee thread safety in the C implementation either.
However, that doesn’t mean we should allow segmentation faults. (thread-safe and segmentation fault are fully different issues, at least we should guarantee thread-unsafe with memory-safe implementation.)
|
Thanks @ZeroIntensity for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 12, 2025
…xt__` (pythonGH-135412)" (pythonGH-135439) This reverts commit e6c3039. (cherry picked from commit 7343135) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Jun 19, 2025
…xt__` (python#135412)" (python#135439) This reverts commit e6c3039.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…xt__` (python#135412)" (python#135439) This reverts commit e6c3039.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…xt__` (python#135412)" (python#135439) This reverts commit e6c3039.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…xt__` (python#135412)" (python#135439) This reverts commit e6c3039.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e6c3039.
cc @vstinner @kumaraditya303 @corona10
StringIOmethods in threads on free-threading debug build #135410