{{ message }}
GH-135379: Remove types from stack items in code generator.#135384
Merged
Conversation
…in the instruction definitions
Member
Member
Author
|
I know Cinder uses it, but it isn't part of any public API and we don't want it to be. |
Member
|
Yeah I don't think it should be documented or in What's New either. |
Fidget-Spinner
approved these changes
Jun 11, 2025
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Jun 19, 2025
…thonGH-135384) * Make casts explicit in the instruction definitions
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…thonGH-135384) * Make casts explicit in the instruction definitions
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…thonGH-135384) * Make casts explicit in the instruction definitions
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…thonGH-135384) * Make casts explicit in the instruction definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the types from stack items in the code generator.
E.g
becomes
and the cast from
_PyStackRefto_PyInterpreterFrame *is made explicit in the op definition.This is a net zero change in terms of code size, but removes fiddly code generator code and replaces it with simple casts.
This also means that any future changes to the code generator, specifically for TOS caching, do not have to worry about inserting casts.