{{ message }}
gh-134151 Fix TypeError in email.utils.decode_params() when sorting RFC 2231 continuations - #134687
Merged
Merged
Conversation
…ntinuations on Python 3 and add corresponding test case
bitdancer
reviewed
May 26, 2025
…d update tests for continuation sorting
bitdancer
requested changes
Jun 7, 2025
Contributor
Author
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @bitdancer: please review the changes made to this pull request. |
bitdancer
approved these changes
Jun 7, 2025
bitdancer
added
needs backport to 3.13
picnixz
reviewed
Jun 7, 2025
picnixz
changed the title
picnixz
approved these changes
Jun 7, 2025
picnixz
reviewed
Jun 7, 2025
Member
|
I'll merge this tomorrow if it's not already merged; I'm a bit too tired for writing a commit message now :') |
Contributor
Author
|
Thanks for your guys’ reviews! @picnixz, take care and enjoy your night :D
|
|
Thanks @zangjiucheng for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 8, 2025
…orting RFC 2231 continuations (pythonGH-134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting. (cherry picked from commit bcb6b45) Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
|
GH-135247 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 8, 2025
…orting RFC 2231 continuations (pythonGH-134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting. (cherry picked from commit bcb6b45) Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
picnixz
pushed a commit
that referenced
this pull request
Jun 8, 2025
…sorting RFC 2231 continuations (GH-134687) (#135248) gh-134151 Fix `TypeError` in `email.utils.decode_params` when sorting RFC 2231 continuations (GH-134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting. (cherry picked from commit bcb6b45) Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
picnixz
pushed a commit
that referenced
this pull request
Jun 8, 2025
…sorting RFC 2231 continuations (GH-134687) (#135247) gh-134151 Fix `TypeError` in `email.utils.decode_params` when sorting RFC 2231 continuations (GH-134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting. (cherry picked from commit bcb6b45) Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Jun 19, 2025
…orting RFC 2231 continuations (python#134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…orting RFC 2231 continuations (python#134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…orting RFC 2231 continuations (python#134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…orting RFC 2231 continuations (python#134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeError: '<' not supported between instances of 'NoneType' and 'int'raised during call toemail.message_from_file#134151