{{ message }}
bpo-36953: Delay removal of ABCs from collections. - #13409
Merged
miss-islington merged 4 commits intoMay 30, 2019
Conversation
tirkarthi
reviewed
May 18, 2019
Contributor
Contributor
Author
The policy is AFAICT removal n+2 after deprecation. We do have to remove at some point no? And adding the version number for removal make it easy to search for all that was marked for removal, as well as give expectation to readers. In any case here we are just discussing bumping the version number, which should be less controversial than discussing if their should be one. |
asvetlov
approved these changes
May 19, 2019
Member
|
I think this deserves a |
Contributor
Author
Why not... done. |
Carreau
changed the title
Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive tdeprecated-removed.
Co-Authored-By: Xtreak <tir.karthi@gmail.com>
Carreau
force-pushed
the
bump-collections-abcs-removal
branch
from
May 20, 2019 16:34
0ca83e5 to
c34186d
Compare
Contributor
Author
|
Title and commits were mentioning wrong issues; rebased/edited. |
ilevkivskyi
approved these changes
May 21, 2019
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
Thanks for updates, LGTM!
rhettinger
pushed a commit
that referenced
this pull request
Aug 22, 2019
This typo was introduced in GH-13409 when changing the message text.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 22, 2019
This typo was introduced in pythonGH-13409 when changing the message text. (cherry picked from commit c4106af) Co-authored-by: Florian Bruhin <me@the-compiler.org>
rhettinger
pushed a commit
that referenced
this pull request
Aug 22, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
This typo was introduced in pythonGH-13409 when changing the message text.
Contributor
|
Thanks @Carreau for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 9, 2019
Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive to deprecated-removed. https://bugs.python.org/issue36953 (cherry picked from commit eea47e0) Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
miss-islington
added a commit
that referenced
this pull request
Oct 9, 2019
Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive to deprecated-removed. https://bugs.python.org/issue36953 (cherry picked from commit eea47e0) Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
ned-deily
pushed a commit
to ned-deily/cpython
that referenced
this pull request
Oct 14, 2019
Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive to deprecated-removed. https://bugs.python.org/issue36953 (cherry picked from commit eea47e0) Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive to deprecated-removed. https://bugs.python.org/issue36953
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This typo was introduced in pythonGH-13409 when changing the message text.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
This typo was introduced in pythonGH-13409 when changing the message text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.
https://bugs.python.org/issue36953