gh-133677 Skip test in ``test_zipfile`` if not UTF-8 by sharktide · Pull Request #133715 · python/cpython · GitHub
Skip to content

gh-133677 Skip test in test_zipfile if not UTF-8 - #133715

Closed
sharktide wants to merge 2 commits into
python:mainfrom
sharktide:patch-133677
Closed

sharktide wants to merge 2 commits into
python:mainfrom
sharktide:patch-133677

Conversation

@sharktide

Copy link
Copy Markdown
Contributor

gh-133677

#133677 Fixes the test_zipfile fail but not running it if the encoding is not UTF-8

similar to #133706 but for test_zipfile

@sharktide

sharktide commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

@sharktide sharktide changed the title gh-133677Skip test in test_zipfile if not UTF-8 gh-133677 Skip test in test_zipfile if not UTF-8 May 8, 2025
@sharktide

Copy link
Copy Markdown
Contributor Author

@ZeroIntensity Could you please add skip-news

@sharktide

Copy link
Copy Markdown
Contributor Author

@zware Please review since this is directly related to StanFromIreland's #133706

@serhiy-storchaka

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants