{{ message }}
gh-132983: Clean-ups for _zstd - #133670
Merged
Merged
Conversation
13 tasks
Contributor
Member
Author
|
Good question -- this PR was getting too big, so I just submitted the changes to the module-level constants. I intend to go through the functions in a follow-up. A |
AA-Turner
enabled auto-merge (squash)
May 8, 2025 18:16
AA-Turner
disabled auto-merge
May 8, 2025 19:20
emmatyping
previously requested changes
May 8, 2025
emmatyping
left a comment
Member
There was a problem hiding this comment.
I have one request but otherwise I think these changes look like great clean ups. Thanks!
This reverts commit e02f66c.
Rogdham
reviewed
May 9, 2025
picnixz
reviewed
May 9, 2025
picnixz
approved these changes
May 9, 2025
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2025
(cherry picked from commit c2a5d4b) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

cc @Rogdham (can't request review).
Best reviewed commit-by-commit.
This contains several clean-ups for the
_zstdmodule._compressionLevel_valuesis replaced with a single int constant, the default compression levelzstd_version_infois initialised from the macros, removing version decomposition arithmetic_ZSTD_CStreamSizes_ZSTD_DStreamSizeswithZSTD_DStreamOutSize_ZSTD_Configset_zstd_error()add_parametersfunction and use the existingPyModule_AddIntMacrorather than defining a local equivalentcompression.zstdA