gh-132775: Add _PyFunction_GetXIData() by ericsnowcurrently · Pull Request #133481 · python/cpython · GitHub
Skip to content

gh-132775: Add _PyFunction_GetXIData() - #133481

Merged
ericsnowcurrently merged 2 commits into
python:mainfrom
ericsnowcurrently:add-pyfunction-getxidata
May 12, 2025
Merged

gh-132775: Add _PyFunction_GetXIData()#133481
ericsnowcurrently merged 2 commits into
python:mainfrom
ericsnowcurrently:add-pyfunction-getxidata

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 6, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

(This is based on gh-133480, thus only the last commit.)

@bedevere-app bedevere-app Bot mentioned this pull request May 6, 2025
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 6, 2025
Merged
@ericsnowcurrently
ericsnowcurrently force-pushed the add-pyfunction-getxidata branch from d762347 to 4a195d8 Compare May 8, 2025 16:07
@ericsnowcurrently
ericsnowcurrently marked this pull request as ready for review May 8, 2025 16:08
@ericsnowcurrently ericsnowcurrently added the needs backport to 3.14 bugs and security fixes label May 8, 2025
neonene
neonene reviewed May 8, 2025
View reviewed changes
Comment thread Python/crossinterp_data_lookup.h Outdated

@neonene neonene May 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not confusing, but the triple negation (non, less, not) looks a bit redundant. I do not think NotShareableError needs "not shareable" in the message.

@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) May 12, 2025 21:44
@ericsnowcurrently
ericsnowcurrently merged commit 8cf4947 into python:main May 12, 2025
@miss-islington-app

miss-islington-app Bot commented May 12, 2025

Copy link
Copy Markdown

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
@ericsnowcurrently @miss-islington
pythongh-132775: Add _PyFunction_GetXIData() (pythongh-133481)
36ef950 
(cherry picked from commit 8cf4947)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@bedevere-app

bedevere-app Bot commented May 12, 2025

Copy link
Copy Markdown

GH-133955 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
@ericsnowcurrently
ericsnowcurrently deleted the add-pyfunction-getxidata branch May 12, 2025 22:13
@bedevere-bot

bedevere-bot commented May 12, 2025

Copy link
Copy Markdown

ericsnowcurrently added a commit that referenced this pull request May 12, 2025
@miss-islington @ericsnowcurrently
[3.14] gh-132775: Add _PyFunction_GetXIData() (gh-133955)
3467656 
(cherry picked from commit 8cf4947, AKA gh-133481)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 26, 2025
Merged
ericsnowcurrently added a commit that referenced this pull request May 27, 2025
@ericsnowcurrently
gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() (gh-13…
9b5e800 
…4758)

This is a small follow-up to gh-133481.  There's a corner case
in the behavior of PyImport_ImportModuleAttrString(), where
it expects __builtins__ to be set if __globals__ is set.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2025
@ericsnowcurrently @miss-islington
pythongh-132775: Always Set __builtins__ In _PyFunction_FromXIData() (p…
99872b1 
…ythongh-134758)

This is a small follow-up to pythongh-133481.  There's a corner case
in the behavior of PyImport_ImportModuleAttrString(), where
it expects __builtins__ to be set if __globals__ is set.
(cherry picked from commit 9b5e800)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@miss-islington miss-islington mentioned this pull request May 27, 2025
Merged
ericsnowcurrently added a commit that referenced this pull request May 27, 2025
@miss-islington @ericsnowcurrently
[3.14] gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() (…
6493395 
…gh-134794)

This is a small follow-up to gh-133481.  There's a corner case
in the behavior of PyImport_ImportModuleAttrString(), where
it expects __builtins__ to be set if __globals__ is set.

(cherry picked from commit 9b5e800, AKA gh-134758)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@ericsnowcurrently @Pranjal095
pythongh-132775: Add _PyFunction_GetXIData() (pythongh-133481)
9232266
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@ericsnowcurrently @Pranjal095
pythongh-132775: Always Set __builtins__ In _PyFunction_FromXIData() (p…
5d23925 
…ythongh-134758)

This is a small follow-up to pythongh-133481.  There's a corner case
in the behavior of PyImport_ImportModuleAttrString(), where
it expects __builtins__ to be set if __globals__ is set.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@ericsnowcurrently @taegyunkim
pythongh-132775: Add _PyFunction_GetXIData() (pythongh-133481)
f136f85
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@ericsnowcurrently @taegyunkim
pythongh-132775: Always Set __builtins__ In _PyFunction_FromXIData() (p…
6e294e1 
…ythongh-134758)

This is a small follow-up to pythongh-133481.  There's a corner case
in the behavior of PyImport_ImportModuleAttrString(), where
it expects __builtins__ to be set if __globals__ is set.
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
@ericsnowcurrently @gostak-dd
pythongh-132775: Always Set __builtins__ In _PyFunction_FromXIData() (p…
4b19395 
…ythongh-134758)

This is a small follow-up to pythongh-133481.  There's a corner case
in the behavior of PyImport_ImportModuleAttrString(), where
it expects __builtins__ to be set if __globals__ is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@neonene neonene neonene left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericsnowcurrently @bedevere-bot @neonene