{{ message }}
GH-132983: Use a standard autoconf version check for zstd - #133479
Merged
Conversation
13 tasks
AA-Turner
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
|
@AA-Turner That looks promising: it seems to handle my use case. Thanks! cc: @emmatyping |
Member
|
... and the |
emmatyping
approved these changes
May 5, 2025
emmatyping
left a comment
emmatyping
left a comment
Member
There was a problem hiding this comment.
Thanks! I didn't know this was something one could do. TIL
I'd like to wait for a RHEL8 buildbot to go green before merging to ensure that it works when there is a version of libzstd that is too old. Otherwise it looks much better.
Member
|
And thank you for catching the original issue @ned-deily ! |
Member
There is always something in Autotools that no one knows you can do. |
Member
Author
4 tasks
emmatyping
added a commit
to emmatyping/cpython
that referenced
this pull request
May 7, 2025
pythonGH-133479 removed the logic to check for libzstd outside of pkg-config. This commit adds that logic back with a check for the version so that users can provide their own libzstd. This is to bring parity with lzma, bz2, and zlib detection.
emmatyping
added a commit
to emmatyping/cpython
that referenced
this pull request
May 12, 2025
pythonGH-133479 removed the logic to check for libzstd outside of pkg-config. This commit adds that logic back with a check for the version so that users can provide their own libzstd. This is to bring parity with lzma, bz2, and zlib detection.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @ned-deily, it seems that this works & is simpler? I'll run buildbots.
A