gh-133351: Fix remote PDB's multi-line block tab completion by godlygeek · Pull Request #133387 · python/cpython · GitHub
Skip to content

gh-133351: Fix remote PDB's multi-line block tab completion #133387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaogaotiantian merged 1 commit into from
May 4, 2025
+51 −3
Merged

gh-133351: Fix remote PDB's multi-line block tab completion #133387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions Lib/pdb.py
View file
Open in desktop
38 changes: 38 additions & 0 deletions Lib/test/test_remote_pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,44 @@ def test_completion_in_pdb_state(self):
expected_state={"state": "pdb"},
)

def test_multiline_completion_in_pdb_state(self):
"""Test requesting tab completions at a (Pdb) continuation prompt."""
# GIVEN
incoming = [
Comment on lines +535 to +537

@StanFromIreland StanFromIreland May 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Test requesting tab completions at a (Pdb) continuation prompt."""
# GIVEN
incoming = [
"""Test requesting tab completions at a (Pdb) continuation prompt."""
incoming = [

@gaogaotiantian gaogaotiantian May 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of agree that #GIVEN is unnecessary here. However, that's consistent with other tests and it's not super important at this point. I do think in the future we should have a cleanup PR to clean these out. It's kind of redundent at this point.

("server", {"prompt": "(Pdb) ", "state": "pdb"}),
("user", {"prompt": "(Pdb) ", "input": "if True:"}),
(
"user",
{
"prompt": "... ",
"completion_request": {
"line": " b",
"begidx": 4,
"endidx": 5,
},
"input": " bool()",
},
),
("server", {"completions": ["bin", "bool", "bytes"]}),
("user", {"prompt": "... ", "input": ""}),
]
self.do_test(
incoming=incoming,
expected_outgoing=[
{
"complete": {
"text": "b",
"line": "! b",
"begidx": 2,
"endidx": 3,
}
},
{"reply": "if True:\n bool()\n"},
],
expected_completions=["bin", "bool", "bytes"],
expected_state={"state": "pdb"},
)

def test_completion_in_interact_state(self):
"""Test requesting tab completions at a >>> prompt."""
incoming = [
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2025-05-04-13-46-20.gh-issue-133351.YsZls1.rst
View file
Open in desktop