{{ message }}
GH-133171: Prevent combinations of --disable-gil and --enable-experimental-jit (for now)#133179
Merged
Merged
Conversation
brandtbucher
added
build
brandtbucher
requested review from
a team,
corona10,
erlend-aasland and
savannahostrowski
as code owners
7 tasks
brandtbucher
changed the title
--disable-gil *and* --enable-experimental-jit (for now)--disable-gil and --enable-experimental-jit (for now)
Member
Author
zooba
reviewed
Apr 30, 2025
Member
There was a problem hiding this comment.
Strictly speaking this would be better as target in pythoncore.vcxproj (see the existing _WarnAboutZlib for example), since there's no requirement to use the batch file, and it's very easy to bypass it. (The same goes for the PGO warning above, I don't remember when that was added.)
But it's not a big deal. It's relatively temporary code anyway
Member
Author
There was a problem hiding this comment.
Yeah, this will only be around for 3.14. I could just put an #error in the C source or whatever, but I figure failing early is best.
Besides, it's not like there's anything wrong with enabling both features. It just doesn't work the way you'd expect.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…xperimental-jit... for now (pythonGH-133179)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.