{{ message }}
gh-67766: Improve struct.pack out of range error messages - #132857
Closed
StanFromIreland wants to merge 5 commits into
Closed
StanFromIreland wants to merge 5 commits into
StanFromIreland wants to merge 5 commits into
Conversation
Member
Author
skirpichev
reviewed
Apr 24, 2025
skirpichev
approved these changes
Apr 26, 2025
skirpichev
left a comment
skirpichev
left a comment
Member
There was a problem hiding this comment.
LGTM
I don't like you added argument index to the module state, but alternatives looks more complex.
Member
|
AFAICS, putting the argument index in module state is not thread-safe. I think the best way to solve this would switching all packing operations to use a new per-operation state struct, which would include a (borrowed) pointer to the module state. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--132857.org.readthedocs.build/