This should get a test case.

The specific change or os.getlogin generally?

The existing (unconditionally skipped) test could be re-enabled, but it doesn't test very much at all, and presumably will still fail on some CI systems. Perhaps we could expand it to get the "correct" result to check against via a shell command? Then if/when it fails on specific platforms either skip or special-case the test for them?

Testing the specific change: I can add a multi-threaded test, but it would ideally be conditional on having getlogin_r or it would crash on platforms that don't (assuming there actually are any). Probably easiest to just selectively skip the test on any such platforms I suppose.

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 675342c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132751%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

Buildbot failures look unrelated to me.

Thanks @duaneg for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

Thanks @duaneg for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

Sorry, @duaneg and @colesbury, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1ffe913c2017b44804aca18befd45689df06c069 3.13

GH-135097 is a backport of this pull request to the 3.14 branch.

GH-135098 is a backport of this pull request to the 3.13 branch.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 NoGIL Refleaks 3.14 (tier-1) has failed when building commit d8c2bfa.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1774/builds/150) and take a look at the build logs.
4. Check if the failure is related to this commit (d8c2bfa) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1774/builds/150

Failed tests:

• test.test_concurrent_futures.test_interpreter_pool

Failed subtests:

• test_free_reference - test.test_concurrent_futures.test_interpreter_pool.InterpreterPoolExecutorTest.test_free_reference

Test leaking resources:

• test_interpreter_pool: memory blocks

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.itamaro-centos-aws.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 220, in test_free_reference
    for _ in support.sleeping_retry(support.SHORT_TIMEOUT):
             ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.itamaro-centos-aws.refleak.nogil/build/Lib/test/support/__init__.py", line 2591, in sleeping_retry
    for _ in busy_retry(timeout, err_msg, error=error):
             ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.itamaro-centos-aws.refleak.nogil/build/Lib/test/support/__init__.py", line 2561, in busy_retry
    raise AssertionError(msg)
AssertionError: timeout (68.3 seconds)