{{ message }}
bpo-36620 [First-time contributor] Update itertools.rst add optional args to function definitions. - #13210
Closed
yingw787 wants to merge 6 commits into
Closed
bpo-36620 [First-time contributor] Update itertools.rst add optional args to function definitions.#13210yingw787 wants to merge 6 commits into
yingw787 wants to merge 6 commits into
Conversation
Contributor
Author
|
@lisroach pls review thanks :) |
lisroach
requested changes
May 8, 2019
| @@ -0,0 +1 @@ | |||
| Update itertools documentation with optional args registration. No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Can you actually remove the NEWS entry? For small documentation fixes an NEWS entry isn't really needed, and can end up cluttering up the news at the end of the day.
Contributor
Author
There was a problem hiding this comment.
@lisroach should be removed! I thought it was required because the CI checks had a large red X on not having a NEWS entry filled out, then the category disappeared after I filled it out (not sure if it's because I filled it out and it completed or if the CI checks deleted the category after PR instantiation).
Contributor
Author
There was a problem hiding this comment.
Okay I get it now; the .rst file must be present but the entry is "skip news" for the bot to skip news. Updated.
jcfr
added a commit
to python-cmake-buildsystem/cpython
that referenced
this pull request
Jan 22, 2020
…om VS2008 to VS2010." This commit is a partial backport of python/cpython@401f9f3. It was originally designed to work with python-cmake-buildsystem. The following modules have NOT been backported: * Tools/msi * Tools/buildbot * PCBuild
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36620