gh-131544: Update docs for PyType_AddWatcher by corona10 · Pull Request #132015 · python/cpython · GitHub
Skip to content

gh-131544: Update docs for PyType_AddWatcher - #132015

Merged
corona10 merged 3 commits into
python:mainfrom
corona10:gh-131544
Apr 2, 2025
Merged

corona10 merged 3 commits into
python:mainfrom
corona10:gh-131544

Conversation

@corona10

@corona10 corona10 commented Apr 2, 2025

Copy link
Copy Markdown
Member

@corona10
corona10 requested review from colesbury and vstinner April 2, 2025 13:58
@bedevere-app bedevere-app Bot added awaiting core review docs Documentation in the Doc dir skip news labels Apr 2, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Apr 2, 2025
@corona10 corona10 added needs backport to 3.13 bugs and security fixes and removed docs Documentation in the Doc dir skip news labels Apr 2, 2025
@corona10

corona10 commented Apr 2, 2025

Copy link
Copy Markdown
Member Author

Comment thread Doc/c-api/type.rst Outdated
exception.

In free-threaded builds, :c:func:`PyType_AddWatcher` is not thread-safe,
so it must be called at start up.

@vstinner vstinner Apr 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe: "so it must be called at start up (before spawning the first thread)."

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10
corona10 enabled auto-merge (squash) April 2, 2025 15:02
@corona10
corona10 merged commit 25275bd into python:main Apr 2, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Apr 2, 2025
@miss-islington-app

Copy link
Copy Markdown

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2025
(cherry picked from commit 25275bd)

Co-authored-by: Donghee Na <donghee.na@python.org>
@bedevere-app

bedevere-app Bot commented Apr 2, 2025

Copy link
Copy Markdown

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Apr 2, 2025
@corona10
corona10 deleted the gh-131544 branch April 2, 2025 16:17
corona10 added a commit that referenced this pull request Apr 2, 2025
…32019)

gh-131544: Update docs for PyType_AddWatcher (gh-132015)
(cherry picked from commit 25275bd)

Co-authored-by: Donghee Na <donghee.na@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants