GH-131296: move suppression of "unused label" warning for clang-cl on Windows - #131900
Conversation
from global pyproject-clangcl.props to ceval.c
There was a problem hiding this comment.
On Windows, clang-cl does not define __GNUC__ (in contrast to Linux), so let's add __clang__ here.
Slightly further down, for MSVC the same warning (4102) is suppressed using #pragma warning(disable:4102), which clang-cl unfortunately does not understand (yet).
The only occurrences of this warning in the whole code base stem from "generated_cases.c.h", so this is a better place to suppress it in case of clang-cl, instead of doing it globally via pyproject-clangcl.props.
| --> | ||
| <ExceptionHandling>Async</ExceptionHandling> | ||
| <AdditionalOptions>-Wno-deprecated-non-prototype -Wno-unused-label -Wno-pointer-sign -Wno-incompatible-pointer-types-discards-qualifiers -Wno-unused-function %(AdditionalOptions)</AdditionalOptions> | ||
| <AdditionalOptions>-Wno-pointer-sign -Wno-incompatible-pointer-types-discards-qualifiers -Wno-unused-function %(AdditionalOptions)</AdditionalOptions> |
There was a problem hiding this comment.
-Wno-unused-label is moved to ceval.c.
-Wno-deprecated-non-prototype is removed, because it does not "fire" for the whole code base.
|
Failing of |
I'm busy right now but from the brief look I did, it seems homebrew changed the directory of where clang 19 is installed. I can only fix it tomorrow, but if you want to take a try you can fix the directory in the CI file today #131895 (comment) |
|
All commit authors signed the Contributor License Agreement. |
5 participants
I think this is a skip news?