gh-131853: test binary header in `msgfmt` generated file by StanFromIreland · Pull Request #131854 · python/cpython · GitHub
Skip to content

gh-131853: test binary header in msgfmt generated file - #131854

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
StanFromIreland:msgfmt-tests
Mar 29, 2025
Merged

gh-131853: test binary header in msgfmt generated file#131854
serhiy-storchaka merged 2 commits into
python:mainfrom
StanFromIreland:msgfmt-tests

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Mar 28, 2025

Copy link
Copy Markdown
Member

skip-news please this is just a test change

@StanFromIreland

Copy link
Copy Markdown
Member Author

@picnixz picnixz changed the title gh-131853: Test binary header in generated file gh-131853: test binary header in msgfmt generated file Mar 28, 2025
Comment thread Lib/test/test_tools/test_msgfmt.py Outdated
@StanFromIreland
StanFromIreland requested a review from tomasr8 March 28, 2025 20:29
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/509/builds/8786) and take a look at the build logs.
  4. Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/509/builds/8786

Failed tests:

  • test_tools

Failed subtests:

  • test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1565/builds/1752) and take a look at the build logs.
  4. Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1565/builds/1752

Failed tests:

  • test_tools

Failed subtests:

  • test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

@StanFromIreland

StanFromIreland commented Mar 29, 2025

Copy link
Copy Markdown
Member Author

@tomasr8 We shouldn't have added the =, s390x is big endian

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO + PGO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/442/builds/8877) and take a look at the build logs.
  4. Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/442/builds/8877

Failed tests:

  • test_tools

Failed subtests:

  • test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto-pgo/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

@serhiy-storchaka

Copy link
Copy Markdown
Member

Oh, there is an issue with ending.

This test should use a just generated file, not a checked in binary file.

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 LTO + PGO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1578/builds/1758) and take a look at the build logs.
  4. Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1578/builds/1758

Failed tests:

  • test_tools

Failed subtests:

  • test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.lto-pgo/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/567/builds/8793) and take a look at the build logs.
  4. Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/567/builds/8793

Failed tests:

  • test_tools

Failed subtests:

  • test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

@StanFromIreland

Copy link
Copy Markdown
Member Author

@serhiy-storchaka What do you want to do, how do we want to deal with big-endian systems?

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 LTO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1587/builds/1764) and take a look at the build logs.
  4. Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1587/builds/1764

Failed tests:

  • test_tools

Failed subtests:

  • test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.lto/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

@serhiy-storchaka

Copy link
Copy Markdown
Member

See #131854.

@StanFromIreland

Copy link
Copy Markdown
Member Author

I can't edit so correction: #131879

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1636/builds/27) and take a look at the build logs.
  4. Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1636/builds/27

Failed tests:

  • test_tools

Failed subtests:

  • test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Clang 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1670/builds/27) and take a look at the build logs.
  4. Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1670/builds/27

Failed tests:

  • test_tools

Failed subtests:

  • test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

@StanFromIreland
StanFromIreland deleted the msgfmt-tests branch March 29, 2025 13:55
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO + PGO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1627/builds/27) and take a look at the build logs.
  4. Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1627/builds/27

Failed tests:

  • test_tools

Failed subtests:

  • test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header
  • test_timerfd_ns_poll - test.test_os.TimerfdTests.test_timerfd_ns_poll
  • test_timerfd_select - test.test_os.TimerfdTests.test_timerfd_select

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto-pgo/build/Lib/test/test_os.py", line 4512, in test_timerfd_ns_poll
    self.check_timerfd_poll(True)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto-pgo/build/Lib/test/test_os.py", line 4497, in check_timerfd_poll
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 4 != 1


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto-pgo/build/Lib/test/test_os.py", line 4452, in test_timerfd_select
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 3 != 1


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto-pgo/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1654/builds/27) and take a look at the build logs.
  4. Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1654/builds/27

Failed tests:

  • test_tools

Failed subtests:

  • test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

@bedevere-bot

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants