iframe-proxy

picnixz · 2025-03-24T14:49:22Z

This is a cleanup PR but it's easier to hunt non-covered possible UBSans

Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

picnixz · 2025-03-24T16:12:01Z

picnixz · 2025-03-24T17:53:22Z

I think it know what happened! I incorrectly merged main into this branch c:

Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner

LGTM

bedevere-bot · 2025-04-01T18:07:26Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Refleaks 3.x (tier-3) has failed when building commit edbf7fb.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1613/builds/1061) and take a look at the build logs.
Check if the failure is related to this commit (edbf7fb) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1613/builds/1061

Failed tests:

test.test_concurrent_futures.test_interpreter_pool

Failed subtests:

test_map_buffersize - test.test_concurrent_futures.test_interpreter_pool.InterpreterPoolExecutorTest.test_map_buffersize

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/test_concurrent_futures/executor.py", line 100, in test_map_buffersize
    res = self.executor.map(str, ints, buffersize=buffersize)
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/_base.py", line 614, in map
    fs = collections.deque(
        self.submit(fn, *args) for args in islice(zipped_iterables, buffersize)
    )
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/_base.py", line 615, in <genexpr>
    self.submit(fn, *args) for args in islice(zipped_iterables, buffersize)
    ~~~~~~~~~~~^^^^^^^^^^^
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/thread.py", line 202, in submit
    raise self.BROKEN(self._broken)
concurrent.futures.interpreter.BrokenInterpreterPool: A thread initializer failed, the thread pool is not usable anymore


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/thread.py", line 99, in _worker
    ctx.initialize()
    ~~~~~~~~~~~~~~^^
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/interpreter.py", line 132, in initialize
    self.interpid = _interpreters.create(reqrefs=True)
                    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
interpreters.InterpreterError: interpreter creation failed


Traceback (most recent call last):
  File "<frozen getpath>", line 358, in <module>
ValueError: embedded null byte
Exception in initializer:
RuntimeError: error evaluating path


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 814, in gc_collect
    gc.collect()
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('127.0.0.1', 40376), raddr=('127.0.0.1', 40377)>
Task was destroyed but it is pending!
task: <Task pending name='Task-1035' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x841c2f290>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=8>
k


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/thread.py", line 99, in _worker
    ctx.initialize()
    ~~~~~~~~~~~~~~^^
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/interpreter.py", line 132, in initialize
    self.interpid = _interpreters.create(reqrefs=True)
                    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
interpreters.InterpreterError: interpreter creation failed
Timeout (0:45:00)!
Thread 0x000000082e37b000 (most recent call first):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/thread.py", line 116 in _worker
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/threading.py", line 996 in run
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/threading.py", line 1054 in _bootstrap_inner
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/threading.py", line 1016 in _bootstrap

picnixz added 15 commits March 24, 2025 13:16

remove un-necessary casts to PyCFunction

70861ec

remove un-necessary casts to getter

d356465

remove un-necessary casts to setter

f641773

remove un-necessary casts for initproc

a197210

add TODO note to remove casts to destructor

5a39cb7

un-necessary cast for module free functions

222b662

fixup: None and NoneType

ad434c0

fixup: _PyDictViewObject

2fea60f

fixup: bool_invert

47bc0ee

fixup: PyUnicodeObject methods

a894c4c

fixup: rangeobject

1c17bfc

fixup: zoneinfo_init_subclass

e415739

fixup: ga_iter

86bc47c

fixup: hamt_baseiter_tp_iternext

5d98a84

remove dead code

1053101

picnixz added the skip news label Mar 24, 2025

bedevere-app Bot mentioned this pull request Mar 24, 2025

UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Closed

Merge branch 'main' into fix/ubsan/casts-111178

5e68e29

Merge branch 'main' into fix/ubsan/casts-111178

937aa63

picnixz commented Mar 24, 2025

View reviewed changes

Comment thread Include/cpython/object.h Outdated

Update Include/cpython/object.h

9c780ad

Merge remote-tracking branch 'upstream/main' into fix/ubsan/casts-111178

3124512

picnixz marked this pull request as ready for review March 30, 2025 09:07

picnixz requested review from ammaraskar, corona10, ericsnowcurrently, markshannon and rhettinger as code owners March 30, 2025 09:07

picnixz requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners March 30, 2025 09:07

bedevere-app Bot added the awaiting core review label Mar 30, 2025

fixup comments

92d648e

picnixz requested review from vstinner and removed request for 1st1, ammaraskar, asvetlov, corona10, ericsnowcurrently, kumaraditya303, markshannon, methane, rhettinger and willingc March 30, 2025 09:11

Merge branch 'main' into fix/ubsan/casts-111178

25c2a3f

vstinner reviewed Apr 1, 2025

View reviewed changes

Comment thread Modules/faulthandler.c Outdated

Comment thread Python/ceval.c Outdated

Comment thread Include/cpython/object.h Outdated

Update Modules/faulthandler.c

4bf2a1e

Co-authored-by: Victor Stinner <vstinner@python.org>

picnixz commented Apr 1, 2025

View reviewed changes

Comment thread Include/cpython/object.h Outdated

Comment thread Python/ceval.c Outdated

picnixz added 2 commits April 1, 2025 15:45

Update Include/cpython/object.h

db5dae1

Update Python/ceval.c

6cfed6c

vstinner approved these changes Apr 1, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 1, 2025

picnixz merged commit edbf7fb into python:main Apr 1, 2025

bedevere-app Bot removed the awaiting merge label Apr 1, 2025

picnixz deleted the fix/ubsan/casts-111178 branch April 1, 2025 15:18

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

Uh oh!

gh-111178: remove redundant casts for functions with correct signatures - #131673

gh-111178: remove redundant casts for functions with correct signatures#131673
picnixz merged 24 commits into
python:mainfrom
picnixz:fix/ubsan/casts-111178

picnixz commented Mar 24, 2025 •

edited

Loading

Uh oh!

picnixz commented Mar 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

picnixz commented Mar 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Uh oh!

bedevere-bot commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

picnixz commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

picnixz commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

picnixz commented Mar 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Apr 1, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

picnixz commented Mar 24, 2025 •

edited

Loading

picnixz commented Mar 24, 2025 •

edited

Loading