{{ message }}
GH-131296: fix clang-cl warning on Windows in _wmimodule.cpp - #131587
Merged
Conversation
chris-eibl
changed the title
chris-eibl
commented
Mar 22, 2025
Member
Author
There was a problem hiding this comment.
fix warning : unused variable 'result' [-Wunused-variable]
chris-eibl
changed the title
Member
|
@chris-eibl Just FYI, I'm rewriting a lot of your PR titles when we commit. It's not a problem - part of what we do as core devs - but you probably haven't noticed, so figured I'd mention it in case you wanted to check them. It's unfortunate that they follow the PR title by default, because your PR titles are fine. But commit messages are more likely to be read without context (in this case, without timeliness - they'll be read in the future when there isn't a flurry of clang-cl warnings being dealt with), so we tend to go a bit more neutral with them. |
Member
Author
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a skip news?