{{ message }}
gh-124666: Improve thread cleanup in test_android - #131427
Merged
Merged
Conversation
Member
Author
|
🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 4997d1b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131427%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
freakboy3742
approved these changes
Mar 18, 2025
freakboy3742
left a comment
freakboy3742
left a comment
Contributor
There was a problem hiding this comment.
Seems like a reasonable set of fixes to me. If nothing else, I guess this means the failure case will actually fail, rather than timing out, which is a definite improvement; maybe the new failure will reveal more detail about why it's failing? (We can but hope :-) )
|
Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2025
) Ensures that failures in test setup don't result in dangling threads. (cherry picked from commit 01b5abb) Co-authored-by: Malcolm Smith <smith@chaquo.com>
freakboy3742
pushed a commit
that referenced
this pull request
Mar 19, 2025
colesbury
pushed a commit
to colesbury/cpython
that referenced
this pull request
Mar 20, 2025
Ensures that failures in test setup don't result in dangling threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hanging buildbot in #124666 was caused by a leftover thread created in the test's
setUpmethod. It was supposed to be cleaned up bytearDown, but that isn't called automatically whensetUpfails.I still don't know why the underlying test failure was happening, but I've increased all the timeouts to
LOOPBACK_TIMEOUT(10 seconds) in case that makes a difference.Also cleaned up a couple of other test failure logging issues.