gh-93096: Move `random` benchmark into pyperformance by donbarbos · Pull Request #131144 · python/cpython · GitHub
Skip to content

gh-93096: Move random benchmark into pyperformance - #131144

Closed
donbarbos wants to merge 2 commits into
python:mainfrom
donbarbos:issue-93096-random
Closed

gh-93096: Move random benchmark into pyperformance#131144
donbarbos wants to merge 2 commits into
python:mainfrom
donbarbos:issue-93096-random

Conversation

@donbarbos

@donbarbos donbarbos commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

@donbarbos

Copy link
Copy Markdown
Contributor Author

Comment thread Misc/NEWS.d/next/Library/2025-03-12-14-55-56.gh-issue-93096.HfBYPA.rst Outdated

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @hugovk

@rhettinger

Copy link
Copy Markdown
Contributor

This isn't a performance test. It is used by module maintainers to view generated distributions to see if they match the expected distributions.

@rhettinger
rhettinger requested a review from tim-one March 12, 2025 17:21
@donbarbos

Copy link
Copy Markdown
Contributor Author

I think it would be right to get rid of the --test flags in modules with cli.
This flag is not documented and is not displayed in the --help output.

And it seems author of this flag is not against removing it

@rhettinger

Copy link
Copy Markdown
Contributor

@rhettinger rhettinger closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants