gh-93096: Remove run block in `heapq` by donbarbos · Pull Request #131130 · python/cpython · GitHub
Skip to content

gh-93096: Remove run block in heapq - #131130

Closed
donbarbos wants to merge 1 commit into
python:mainfrom
donbarbos:issue-93096-heapq
Closed

gh-93096: Remove run block in heapq#131130
donbarbos wants to merge 1 commit into
python:mainfrom
donbarbos:issue-93096-heapq

Conversation

@donbarbos

@donbarbos donbarbos commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

we can use next command for doctests: ./python -m doctest Lib/heapq.py -v

and we already loading doctest in next line:

@donbarbos

Copy link
Copy Markdown
Contributor Author

cc @vstinner

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhettinger

Copy link
Copy Markdown
Contributor

I don't think this addresses any known or real user problem. It just makes life more difficult for the module maintainer.

@donbarbos

Copy link
Copy Markdown
Contributor Author

@rhettinger rhettinger closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants