gh-111178: fix clang-cl compilation of Modules/mmapmodule.c by chris-eibl · Pull Request #130446 · python/cpython · GitHub
Skip to content

gh-111178: fix clang-cl compilation of Modules/mmapmodule.c - #130446

Merged
picnixz merged 2 commits into
python:mainfrom
chris-eibl:clang-cl_fix_for_mmapmodule.c
Feb 22, 2025
Merged

gh-111178: fix clang-cl compilation of Modules/mmapmodule.c#130446
picnixz merged 2 commits into
python:mainfrom
chris-eibl:clang-cl_fix_for_mmapmodule.c

Conversation

@chris-eibl

@chris-eibl chris-eibl commented Feb 22, 2025

Copy link
Copy Markdown
Member

After #129784 clang-cl fails with a compilation error for mmap__sizeof__method in Modules/mmapmodule.c:

..\Modules\mmapmodule.c(1201,25): error : incompatible function pointer types initializing 'PyCFunction' (aka 'struct _object *(*)(struct _object *, struct _object *)') with an expression of type 'PyObject *(PyObject *, void *)' (aka 's
truct _object *(struct _object *, void *)') [-Wincompatible-function-pointer-types] [e:\cpython_clang\PCbuild\pythoncore.vcxproj]

I think this is a skip-news.

Comment thread Modules/mmapmodule.c Outdated
@picnixz

picnixz commented Feb 22, 2025

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz
picnixz merged commit 65b339c into python:main Feb 22, 2025
@picnixz

picnixz commented Feb 22, 2025

Copy link
Copy Markdown
Member

@chris-eibl
chris-eibl deleted the clang-cl_fix_for_mmapmodule.c branch February 23, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants