gh-107773: Make `datetime` subclass `repr` consistent both implementations by donbarbos · Pull Request #130308 · python/cpython · GitHub
Skip to content

gh-107773: Make datetime subclass repr consistent both implementations - #130308

Merged
jaraco merged 9 commits into
python:mainfrom
donbarbos:issue-107773
Feb 23, 2025
Merged

gh-107773: Make datetime subclass repr consistent both implementations#130308
jaraco merged 9 commits into
python:mainfrom
donbarbos:issue-107773

Conversation

@donbarbos

@donbarbos donbarbos commented Feb 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

New behavior:

>>> class A(_datetime.time): pass
...
>>> class B(_pydatetime.time): pass
...
>>> repr(A(1))
'A(1, 0)'
>>> repr(B(1)) # or str()
'B(1, 0)'

Old behavior:

>>> class A(_datetime.time): pass
...
>>> class B(_pydatetime.time): pass
...
>>> repr(A(1))
'A(1, 0)'
>>> repr(B(1)) # or str()
'__main__.B(1, 0)'

@bedevere-app bedevere-app Bot mentioned this pull request Feb 19, 2025
Closed
@mattip

mattip commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

jaraco
jaraco approved these changes Feb 23, 2025
View reviewed changes

@jaraco jaraco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach. Thank you for developing it!

Just a couple of minor comments about the test implementation and I think this is good to go.

Comment thread Lib/test/datetimetester.py
Comment thread Lib/test/datetimetester.py
Comment thread Lib/test/datetimetester.py
Comment thread Lib/test/datetimetester.py Outdated
@donbarbos

donbarbos commented Feb 23, 2025

Copy link
Copy Markdown
Contributor Author

@jaraco thank you for the comments, I added your suggestions 👍

@donbarbos

donbarbos commented Feb 23, 2025

Copy link
Copy Markdown
Contributor Author

Sorry, I was in a hurry to ping you, but now everything seems to be ready

@jaraco
jaraco merged commit 81a9b53 into python:main Feb 23, 2025
@bedevere-bot

bedevere-bot commented Feb 23, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO + PGO 3.x has failed when building commit 81a9b53.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/78/builds/8483) and take a look at the build logs.
  4. Check if the failure is related to this commit (81a9b53) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/78/builds/8483

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_interpreters/test_stress.py", line 30, in task
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_interpreters/test_stress.py", line 47, in run
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

@jaraco

jaraco commented Feb 24, 2025

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@donbarbos @mattip @bedevere-bot @jaraco