{{ message }}
GH-91079: Implement C stack limits using addresses, not counters.#130007
Merged
Conversation
…m independent constants
encukou
approved these changes
Feb 19, 2025
encukou
left a comment
encukou
left a comment
Member
There was a problem hiding this comment.
Looks great now, thank you!
Would you be OK with me asking the SC to remove Py_C_RECURSION_LIMIT (and c_recursion_remaining) without deprecation? IMO it's the right thing to do here.
Member
Author
|
|
Member
@markshannon if you look at line 427 of https://buildbot.python.org/#/builders/1046/builds/7562/steps/8/logs/stdio you will see that |
Member
|
I opened #130319 and assigned it to @markshannon . |
Contributor
|
This also appears to have caused a failure on the iOS buildbot (masked because there was an existing failure with the colorise tests). However, this build, triggered by the merge of this PR is the first one that has a failure in test_sys |
Contributor
|
@markshannon Looking into the iOS failure - the comment before the test that is failing says: What constitutes "normal" here? Is it possible a sequential, single process run (i.e., how iOS runs the test suite) might trigger this? I'm a bit out my depth here on diagnosing the cause of this one, so any pointers or suggestions for possible causes would be most welcome. |
Member
Author
|
This PR does no refcounting, allocation or deallocation. |
Contributor
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Feb 21, 2025
… counters. (pythonGH-130007)" for now Unfortunatlely, the change broke some buildbots. This reverts commit 2498c22.
markshannon
added a commit
to faster-cpython/cpython
that referenced
this pull request
Feb 24, 2025
…its using addresses, not counters. (pythonGH-130007)" for now (GH130413)" This reverts commit ef29104.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully, this will also fix #113655.