gh-111178: fix UBSan failures in `Modules/selectmodule.c` by picnixz · Pull Request #129792 · python/cpython · GitHub
Skip to content

gh-111178: fix UBSan failures in Modules/selectmodule.c - #129792

Merged
encukou merged 13 commits into
python:mainfrom
picnixz:fix/ubsan/select-111178
Feb 24, 2025
Merged

gh-111178: fix UBSan failures in Modules/selectmodule.c#129792
encukou merged 13 commits into
python:mainfrom
picnixz:fix/ubsan/select-111178

Conversation

@picnixz

@picnixz picnixz commented Feb 7, 2025

Copy link
Copy Markdown
Member

This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.

@picnixz
picnixz marked this pull request as ready for review February 7, 2025 18:09

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz

picnixz commented Feb 23, 2025

Copy link
Copy Markdown
Member Author

@picnixz
picnixz requested a review from vstinner February 23, 2025 10:08
@encukou
encukou merged commit 73bbaf3 into python:main Feb 24, 2025
@picnixz
picnixz deleted the fix/ubsan/select-111178 branch February 24, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants