{{ message }}
GH-128563: Generate opcode = ... in instructions that need opcode - #129608
Merged
Merged
Conversation
Fidget-Spinner
changed the title
opocde = ... in instructions that need opcodeopcode = ... in instructions that need opcode
Fidget-Spinner
approved these changes
Feb 3, 2025
Member
There was a problem hiding this comment.
I have a feeling if you remove the uint8_t opcode in the outer loop, and just define it as int opcode = XXX in each bytecode case, there will be a speedup in the normal interpreter as well (or at least, there will be less pressure on the register allocator), as it will free up a single outer variable that is live across all basic blocks.
Member
Author
Member
|
Don't think it's worth diverging the two over that. Let's just keep it simple then and do this. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
…pcode` (pythonGH-129608) * Remove support for GO_TO_INSTRUCTION
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
opcode, generateopcode = ...at the start of the instructionopcodeby using micro-opsGO_TO_INSTRUCTIONmacro as it is no longer needed.This means that we no longer need to pass the
opcodeparameter in tailcalls.Performance is neutral.