gh-62299: Don't set Content-Length for 1xx, 204 and 304 requests by berkerpeksag · Pull Request #12955 · python/cpython · GitHub
Skip to content

gh-62299: Don't set Content-Length for 1xx, 204 and 304 requests - #12955

Open
berkerpeksag wants to merge 2 commits into
python:mainfrom
berkerpeksag:18099-wsgiref-304
Open

gh-62299: Don't set Content-Length for 1xx, 204 and 304 requests#12955
berkerpeksag wants to merge 2 commits into
python:mainfrom
berkerpeksag:18099-wsgiref-304

Conversation

@berkerpeksag

@berkerpeksag berkerpeksag commented Apr 25, 2019 •
edited by serhiy-storchaka
Loading

Copy link
Copy Markdown
Member

@berkerpeksag
berkerpeksag requested a review from vadmium April 25, 2019 22:49
vadmium
vadmium reviewed Apr 30, 2019
View reviewed changes

@vadmium vadmium left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @berkerpeksag, I wrote some comments on Sunday, but I didn’t have time to finish looking at this. Posting what I got so far in case it’s useful.

Comment thread Lib/test/test_wsgiref.py Outdated
Comment thread Lib/wsgiref/handlers.py Outdated
Comment thread Lib/wsgiref/handlers.py

@vadmium vadmium Apr 28, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Christian’s original patch made more sense to me, just checking for the first digit being 1, rather than limiting to these three codes. In the HTTP 1.1 RFC https://tools.ietf.org/html/rfc7230#page-31, it says “A server must not send a Content-Length header field in any response with a status code of 1xx (Informational)”.

@berkerpeksag berkerpeksag Apr 30, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironically, I decided to list all three codes explicitly after I read that section because I had to Google them :) Both styles fine for me.

Comment thread Lib/wsgiref/handlers.py
Comment thread Lib/wsgiref/handlers.py Outdated
@berkerpeksag
berkerpeksag marked this pull request as ready for review May 24, 2019 17:26
@berkerpeksag

berkerpeksag commented May 24, 2019

Copy link
Copy Markdown
Member Author

@vadmium do you have any further comments? I'd like to get this merged this weekend if possible.

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 1, 2026
@serhiy-storchaka serhiy-storchaka changed the title bpo-18099: Don't set Content-Length for 1xx, 204 and 304 requests gh-62299: Don't set Content-Length for 1xx, 204 and 304 requests Aug 12, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadmium vadmium vadmium left review comments

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@berkerpeksag @vadmium @ned-deily @the-knights-who-say-ni @ezio-melotti @bedevere-bot